Andrew Hayzen has proposed merging
lp:~ahayzen/ubuntu-weather-app/fix-click-locations-list into
lp:ubuntu-weather-app.
Commit message:
* Fix clicking on a location in the bottom edge not popping the bottom edge
Requested reviews:
Jenkins Bot (ubuntu-core-apps-jenkins-bot): continuous-integration
Ubuntu Weather Developers (ubuntu-weather-dev)
For more details, see:
https://code.launchpad.net/~ahayzen/ubuntu-weather-app/fix-click-locations-list/+merge/322666
* Fix clicking on a location in the bottom edge not popping the bottom edge
TESTING:
1) Ensure you have two locations
2) Open the bottom edge
3) Click on a location
4) The bottom edge should dismiss and the view switch to the chosen location
--
Your team Ubuntu Weather Developers is requested to review the proposed merge
of lp:~ahayzen/ubuntu-weather-app/fix-click-locations-list into
lp:ubuntu-weather-app.
=== modified file 'app/ui/LocationsPage.qml'
--- app/ui/LocationsPage.qml 2017-04-12 15:48:27 +0000
+++ app/ui/LocationsPage.qml 2017-04-18 09:09:34 +0000
@@ -73,7 +73,7 @@
onItemClicked: {
settings.current = index;
- pageStack.pop()
+ locationsPage.pop()
}
Column {
@@ -161,7 +161,7 @@
settings.current = index;
}
- pageStack.pop()
+ locationsPage.pop()
}
onReorder: {
console.debug("Move: ", from, to);
--
Mailing list: https://launchpad.net/~ubuntu-touch-coreapps-reviewers
Post to : ubuntu-touch-coreapps-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~ubuntu-touch-coreapps-reviewers
More help : https://help.launchpad.net/ListHelp
