= MIR review =
* Builds fine with only main enabled
* Has a test suite. It is enabled in the build. 93 tests, 1 skipped.
test_malformed_datagram ... [SKIPPED]
* If it's a Python package, does it use dh_python3/dh_python2? (look in
debian/rules)
* Not a desktop package
* Ubuntu-only package right now
* ubuntu-server is subscribed
* No watch file, but has 'get-orig-source'
* Not a lot of commits from upstream git. The LP project of the same name just
does a git import of the code from upstream. Commits as recent as last month.
* Package is lintian clean
* debian/rules is fine
* No errors/warnings during the build
* Package is not in Debian, and has no bugs others than this MIR (but the
package is new)
= Security review =
No initscripts or upstart jobs. No dbus services. No setuid applications or use
of fscaps. No use of sudo or sudo fragments. No cron jobs. No security history.
The code looks fine and supportable with <6000 of source (4000+ from the test
suite). It is a python library and doesn't actually do anything on its own. Did
see some bugs:
./tftp/session.py: log.msg("Got error: " % datagram)
./tftp/session.py: log.msg("Got error: " % datagram)
./tftp/bootstrap.py: log.msg("Got error: " % datagram)
All these will result in "TypeError: not all arguments converted during string
formatting" instead of a log message.
ACK-- but please fix the bugs I found and push upstream.
** Changed in: python-tx-tftp (Ubuntu)
Status: New => Fix Committed
** Changed in: python-tx-tftp (Ubuntu)
Assignee: Jamie Strandboge (jdstrand) => (unassigned)
--
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to python-tx-tftp in Ubuntu.
https://bugs.launchpad.net/bugs/1024086
Title:
[MIR] python-tx-tftp
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/python-tx-tftp/+bug/1024086/+subscriptions
--
Ubuntu-server-bugs mailing list
[email protected]
Modify settings or unsubscribe at:
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
