Thanks, Martin.

But, the absence of the enable[d] file is apparently a legitimate case,
and your patch as it stands causes an undesirable error message in the
PM log in that case, such as:

cat: /sys/class/net/wlan0/device/enable*: No such file or directory

Hence my original proposed test for the file's existence.

As an alternative you could have $(cat .... 2>/dev/null) but that would
risk masking a genuine error.

Incidentally, with a fix similar to the one you committed in place, I've
observed that the b43 driver, which gets the default power-save command
(lines 41-2 of wireless script)  currently fails to respect the command,
eg:

# iwconfig wlan0 power on
Error for wireless request "Set Power Management" (8B2C) :
    SET failed on device wlan0 ; Operation not supported.

Although the script has special cases for certain Intel drivers and you
could add eg new line 41 before the default case

    b43) return1;;

I wouldn't recommend doing so both to avoid complexity (don't want it to
end up like pmutils video quirks) and more importantly in case a future
version of the driver fixes the lack of power-saving support.

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to pm-utils in Ubuntu.
https://bugs.launchpad.net/bugs/1544612

Title:
  Missing fix for 1299975 claimed to be in pm-utils (1.4.1-13ubuntu0.1)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/pm-utils/+bug/1544612/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs

Reply via email to