On 27/06/14 16:53, Julien Funk wrote: > Hey team, the justification of disabling a test being "the proper fix is > ... but that's a lot more work", doesn't seem appropriate, regardless of > the time crunch we're seeing. Has someone consulted QA about the disabled > test in question? I have Leo and Brendan looking into it now, should hear > from them soon. Perhaps we can work together on a real process for > disabling tests as this seems to have been an ad hoc decision.
The risk here is that this disabling gets forgotten about. From what I understand so far, this sqlite regression does actually cause a real potentially user facing issue in mediascanner, so why are we letting that slide? Have other options been considered such as reverting sqlite? At a very minimum, as Julien suggests we should make sure that we keep track of such disabled tests and ensure that a real fix is identified that allows us to re-enable them as soon as possible. > > ~Julien > > > On Fri, Jun 27, 2014 at 10:21 AM, Jussi Pakkanen < > [email protected]> wrote: > >> On 27.06.2014 17:06, Jamie Strandboge wrote: >> >> I just did an emergency upload for this. It would be resolved with >>>> 0.101+14.10.20140625-0ubuntu2 but there is an unrelated testsuite >>>> failure that >>>> causes a FTBFS. I have alerted Jussi who is looking at it now. >>>> >>>> FYI, Jussi discovered that the recent sqlite update changed behavior >>> which broke >>> the test suite. >>> >> >> Indeed. Here's an MR for that (it just disables the test): >> >> https://code.launchpad.net/~jpakkane/mediascanner2/ >> sqliteworkaround/+merge/224845 >> >> What this means in practice is that queries with only a few letters won't >> return results. Longer queries keep on working just like before. The proper >> fix is to dive into SQLite and see if the old behaviour can be re-enabled >> but that's a lot more work. >> >> >> -- >> Mailing list: https://launchpad.net/~ubuntu-phone >> Post to : [email protected] >> Unsubscribe : https://launchpad.net/~ubuntu-phone >> More help : https://help.launchpad.net/ListHelp >> > > > -- Mailing list: https://launchpad.net/~ubuntu-phone Post to : [email protected] Unsubscribe : https://launchpad.net/~ubuntu-phone More help : https://help.launchpad.net/ListHelp
