On Mon, Feb 3, 2014 at 1:58 PM, Michel RENON <re...@mr-consultant.net>wrote:
> Hi, > > I noticed a comment in a source file of some core apps : > http://bazaar.launchpad.net/~ubuntu-filemanager-dev/ubuntu- > filemanager-app/trunk/view/head:/VerticalDivider.qml, lines 2:4. > It's obvious that such comment is completely off-topic in a source code, > specially when it's an open-source app under the responsibility of an > international company. > > I was wondering if it's ok to accept such kind of comments : is there any > rule/policy that handle such case? > > If we look in the long term, allowing such comments may result in anyone > writing any kind of comments : some personal humour, some political > opinion, some advertising and finally some span ("enlarge your code !" ;-) > sorry, couldn't resist !) > > Do you remember that months ago, Microsoft had to officially apologize for > a simple constant in a source file ? (1). So I think Canonical should > prevent that kind of problem. > > Wow! I cannot believe that such a comment was accepted in a merge review. >From my point of view the reviewers should have picked this up and recommended that such a comment was/is completely out off-topic and should have not been added. But, this is a community project and those that manage it and are core contributors should be the ones fixing such a comment and requesting the author to deal with it. Religious, political and other type of conversations have no place in the code period. I would ping or community managers to start a conversation about this practices. Regards, Manuel PS: This is not a Canonical statement at all but a personal one. > Regards, > Michel > > > > (1) http://www.forbes.com/sites/adriankingsleyhughes/2012/07/ > 21/microsoft-removes-embarrassing-big-boobs-string-from-linux-code/ > > -- > Mailing list: https://launchpad.net/~ubuntu-phone > Post to : ubuntu-phone@lists.launchpad.net > Unsubscribe : https://launchpad.net/~ubuntu-phone > More help : https://help.launchpad.net/ListHelp >
-- Mailing list: https://launchpad.net/~ubuntu-phone Post to : ubuntu-phone@lists.launchpad.net Unsubscribe : https://launchpad.net/~ubuntu-phone More help : https://help.launchpad.net/ListHelp
