diff -u libxcb-1.0/src/xcb_conn.c libxcb-1.0-sloppy_lock/src/xcb_conn.c --- libxcb-1.0/src/xcb_conn.c 2006-11-22 05:18:48.000000000 +0100 +++ libxcb-1.0-sloppy_lock/src/xcb_conn.c 2007-11-22 15:21:30.000000000 +0100 @@ -62,6 +62,9 @@ static int _xcb_xlib_init(_xcb_xlib *xlib) { xlib->lock = 0; +#ifndef NDEBUG + xlib->sloppy_lock = (getenv("LIBXCB_ALLOW_SLOPPY_LOCK") != 0); +#endif pthread_cond_init(&xlib->cond, 0); return 1; } diff -u libxcb-1.0/src/xcbint.h libxcb-1.0-sloppy_lock/src/xcbint.h --- libxcb-1.0/src/xcbint.h 2006-11-21 08:06:29.000000000 +0100 +++ libxcb-1.0-sloppy_lock/src/xcbint.h 2007-11-22 15:33:00.000000000 +0100 @@ -130,6 +130,7 @@ typedef struct _xcb_xlib { int lock; + int sloppy_lock; pthread_t thread; pthread_cond_t cond; } _xcb_xlib; diff -u libxcb-1.0/src/xcb_xlib.c libxcb-1.0-sloppy_lock/src/xcb_xlib.c --- libxcb-1.0/src/xcb_xlib.c 2006-11-03 02:38:00.000000000 +0100 +++ libxcb-1.0-sloppy_lock/src/xcb_xlib.c 2007-11-22 15:58:56.000000000 +0100 @@ -28,6 +28,38 @@ #include +#ifdef HAVE_BACKTRACE +#include +#include +#include +#endif + +static void xcb_xlib_printbt(void) +{ +#ifdef HAVE_BACKTRACE + void *array[20]; + int size; + char **strings; + int i; + + size = backtrace(array, 20); + strings = backtrace_symbols(array, size); + + fprintf(stderr, "Locking assertion failure. Backtrace:\n"); + + for (i = 0; i < size; ++i) + fprintf(stderr, "#%i %s\n", i, strings[i]); + + free(strings); +#endif +} + +#ifndef NDEBUG +#define xcb_assert(c,x) do { if (!(x)) { xcb_xlib_printbt(); if (!(c)->xlib.sloppy_lock) assert(x); } } while(0) +#else +#define xcb_assert(c,x) +#endif + unsigned int xcb_get_request_sent(xcb_connection_t *c) { if(c->has_error) @@ -38,7 +70,7 @@ void xcb_xlib_lock(xcb_connection_t *c) { _xcb_lock_io(c); - assert(!c->xlib.lock); + xcb_assert(c, !c->xlib.lock); c->xlib.lock = 1; c->xlib.thread = pthread_self(); _xcb_unlock_io(c); @@ -47,8 +79,8 @@ void xcb_xlib_unlock(xcb_connection_t *c) { _xcb_lock_io(c); - assert(c->xlib.lock); - assert(pthread_equal(c->xlib.thread, pthread_self())); + xcb_assert(c, c->xlib.lock); + xcb_assert(c, pthread_equal(c->xlib.thread, pthread_self())); c->xlib.lock = 0; pthread_cond_broadcast(&c->xlib.cond); _xcb_unlock_io(c);