Please make a new "real" ubuntu version in the changelog, i.e. ubuntu3,
so that your patch can be applied and uploaded as is.

A few comments and questions (I just had a quick look at the patch and haven't 
checked the code, and you're definitely more proficient at c++ than I am):
- it's easier to see what you change on the Build-Depends line if you just add 
dpatch to the end.
- the changelog entry might need a colon after LP, like "LP: #bug number".
- there's two variables "now", one double, one timeval.
- the boolean expression "optarg != NULL" might as well be written "optarg" 
(question of taste I guess)
- if you define DEFAULT_FPS to 50, do you need the ==0 logic guarding just 
after it?

-- 
Really Slick Screensavers use 100% CPU
https://bugs.launchpad.net/bugs/129142
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to