Thanks for working on this! A few comments:

a) I find it somewhat confusing that the changelog says that it includes
11_no-ssp.patch and then later says that it's been renamed to 12_no-
ssp.patch.

b) I also find it a bit confusing that "include the no-ssp patch" and
"build with -fno-stack-protector" are separate points, yet the no-ssp
patch is exactly what makes it build with -fno-stack-protector.

c) I believe the current practice is not to bother documenting that
Original-Maintainer mangling and all that.

Suggested resolution for a)+b):

Add a bullet point to the "remaining changes" part, that reads something like:
   - 12_no-ssp.patch (formerly 11_no-ssp.patch): Build with -fno-stack-protector

-- 
Please merge bochs 2.3.7-1 (universe) from Debian unstable (main)
https://bugs.launchpad.net/bugs/244164
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to