Thanks black. I am reviewing this patch and it works much better than
before. One comment and one issue, however.

1) The section "@@ -346,7 +349,7 @@" can be removed since that was
already fixed as a separate patch, which you did (thanks!).

2) There is a bug when removing a theme in the same place that a theme
was already removed from. For example, have >2 themes installed. Remove
the first one, no problem. Try removing the new first one, which used to
be the second:

  File "/usr/share/avant-window-navigator/awn-manager/awnTheme.py", line
315, in delete

    name = self.theme_list[index]['name']

  KeyError: 0

  The same thing happens if you remove say the second theme if you had
three, and now try to remove the "second" theme again which used to be
the third.

  Deceptively, theme_list is actually a dictionary, so that is probably
the issue.

Other than that I can remove multiple themes, including selected and
unselected ones, change applied themes and remove more, et cetera. It
seems quite robust except for that aforementioned bug. Do you think it
is something you can fix? Thanks!

-- 
Cannot remove any theme in awn-manager except the currently enabled one
https://bugs.launchpad.net/bugs/134397
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to