On Fri, Mar 7, 2008 at 11:09 AM, Shawn Smith <[EMAIL PROTECTED]> wrote: > Here's the diff,
Okay, cool, Shawn, you're almost there. > I'm using vim to edit the file and in vim the > whitespace appears to match up. Okay, vim is good! Now the whitespace isn't quite right because there's a difference between individual spaces (the spacebar) and tabs (the tab key). In vim, go up to those other lines and move with your cursor. Does it jump one character at a time, or multiple? If one character, then the previous code is using lots of single spaces. You should do the same. If it jumps blocks at a time, then it's using tabs, and you should do the same. It might well be a combination of both (not my favorite spacing format, but hey....). In any case, you should *definitely* match the standard shown in the rest of the file. As for the code...you define DESC but never use it. Dead code can be confusing and is a no-no. Other than that, this looks good to me. I'd give it a +1. The last thing to do is to generate a real debdiff. I'll post a followup tomorrow with more detailed instructions. :-Dustin -- Samba initscript does not conform to the LSB Spec. https://bugs.launchpad.net/bugs/39157 You received this bug notification because you are a member of Ubuntu Bugs, which is a direct subscriber. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
