Public bug reported:
[Impact]
An extra hunk was mistakenly placed in debian/patches/cephadm-id-fix.patch
during development of 20.2.1, and was found in review of 20.2.4.
55 diff --git a/src/pybind/CMakeLists.txt b/src/pybind/CMakeLists.txt
56 index fb357700a4..240c8949df 100644
57 --- a/src/pybind/CMakeLists.txt
58 +++ b/src/pybind/CMakeLists.txt
59 @@ -70,9 +70,6 @@ if(WITH_MGR)
60 endmacro()
61 get_openssl_soversion(${OPENSSL_VERSION} OPENSSL)
62 get_openssl_soversion(${PYSSL_VER} PYSSL)
63 - if(NOT (OPENSSL_SOVERSION VERSION_EQUAL PYSSL_SOVERSION))
64 - message(FATAL_ERROR "Python and Ceph link to different OpenSSL
versions: ${PYSSL_VER} vs ${OPENSSL_VERSION}")
65 - endif()
66 else()
67 message(WARNING "could not determine ssl version of python crypto lib")
68 endif()
We need to ensure that the openssl version that ceph links with, is the very
same one that python links with, so we will remove this hunk.
[Testcase]
Ceph needs to build correctly on all architectures. Since this is a build time
check, building successfully is enough for verification.
[Where problems can occur]
Re-adding this build time check back in again might cause build failures on
development systems, but we need to know about these early, and build failures
should be seen as welcome, so they can be fixed.
It is more risk knowing that there could be ceph binaries in the archive that
potentially link to different openssl versions than what python links to,
leading to loading different libraries at runtime and potential memory
corruption.
** Affects: ceph (Ubuntu)
Importance: Medium
Assignee: Matthew Ruffell (mruffell)
Status: In Progress
** Affects: ceph (Ubuntu Stonking)
Importance: Medium
Assignee: Matthew Ruffell (mruffell)
Status: In Progress
** Affects: ceph (Ubuntu Tenacious)
Importance: Medium
Assignee: Matthew Ruffell (mruffell)
Status: In Progress
** Also affects: ceph (Ubuntu Stonking)
Importance: Undecided
Status: New
** Also affects: ceph (Ubuntu Tenacious)
Importance: Undecided
Status: New
** Changed in: ceph (Ubuntu Stonking)
Importance: Undecided => Medium
** Changed in: ceph (Ubuntu Tenacious)
Importance: Undecided => Medium
** Changed in: ceph (Ubuntu Stonking)
Status: New => In Progress
** Changed in: ceph (Ubuntu Tenacious)
Status: New => In Progress
** Changed in: ceph (Ubuntu Stonking)
Assignee: (unassigned) => Matthew Ruffell (mruffell)
** Changed in: ceph (Ubuntu Tenacious)
Assignee: (unassigned) => Matthew Ruffell (mruffell)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2172001
Title:
Remove spurious hunk from d/p/cephadm-id-fix.patch
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/2172001/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
