Thanks for reporting this one Gleb. I can confirm this is a regression
in the sense of fresh installations, but it was introduced by design and
will not result in regressions for users upgrading their systems from
24.04 to 26.04 (explanation below).

When checking

https://www.samba.org/samba/docs/current/man-html/smb.conf.5.html vs
https://www.samba.org/samba/docs/4.0/man-html/smb.conf.5.html, I see

"Default: usershare max shares = 0"

in both pages. i.e., at a first glance, this does not look like a
regression.

Now, when we check the ubuntu manpages in
https://manpages.ubuntu.com/manpages/noble/man5/smb.conf.5.html
and
https://manpages.ubuntu.com/manpages/resolute/man5/smb.conf.5.html

we can easily see the difference for the __default__ value of that
configuration there.

noble: "Default: usershare max shares = 100"
resolute: "Default: usershare max shares = 0"

i.e., there is a clear deviation from the upstream project in noble.

In a deeper inspection of our package, I see that up until samba 4.23 (i.e., 
before Ubuntu 26.04), we shipped a patch to change that __default__ value in 
new installations (this change was applied in samba's code base, not a 
configuration change). In Samba 4.23, starting in 26.04, we no longer ship that 
change in favor of the upstream designed default value:
https://salsa.debian.org/samba-team/samba/-/commit/aa2bc8e1090e73609a54088beeb03a2dde17793f
 

To prevent regressions on upgrades to 26.04, we also configure samba to set the 
value to the old Ubuntu default of 100 for users who already had it enabled by 
default:
https://salsa.debian.org/samba-team/samba/-/commit/a400d2da3db50dc05b27c3d2465601190c44e4b0

IMHO, we should not revert the change. Debian did the right call to
stick to the upstream (more secure) design of having the feature
disabled by default, and even did so preventing regressions in working
systems.

What we should do is to add an entry in the Ubuntu release notes
announcing that change. An entry in d/NEWS may not make much sense in
this case since upgrades are covered by the change in postinst.

** Tags added: server-triage-discuss

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2170585

Title:
  net usershare: usershares are currently disabled

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/samba/+bug/2170585/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to