Thanks, Anshul. Here is my review of the packages in the PPA:
* The only diffs in the 1.26 packages are the new patches to skip the flaky tests and the changelog entries LGTM. * in 1.25, other than the changelog entries, we have: - Patch to skip flaky tests.This patch seems to be added as a Delta, but the origin seems to be Debian (I suppose it is from a different golang version). Please, add an "Origin: vendor, $SALSA_URL" DEP3 header to this patch so we know its provenance. - The cmd-compile patch. LGTM (it matches the upstream patch listed in DEP3) - Change dropping golang 1.25 from B-D in favor of 1.24 (LGTM) * All introduced patches are exactly the same across all series. * The deb version suffix used to adjust for upgrade paths works fine, but may be misleading. It would be nice to use ~ubuntu0.22.04.1 instead of ~22.04.1 as a deb version suffix as per https://github.com/ubuntu/ubuntu-project-docs/pull/808 * Since we are changing the version and it is greater than what is available in the PPA, you can merge all former (new) changelog entries in a single one (no need to keep changelog entries for unreleased packages). What do I expect next to proceed with a copy to the archive: 1) new versions for go 1.25 and 1.26 for resolute, noble, and jammy uploaded to the PPA and built successfully 2) Each new upload uses the ~~ubuntu0.XY.AB.N suffix in the debian version 2.1) There is a single changelog entry for the new packages, when compared to their counterparts in the Ubuntu Stonking archive 3) "Origin: vendor, $SALSA_URL" entry in all versions of 0008-Skip- flaky-TestMergeLocalsIntegration-on-s390x.patch. 4) No further changes in those packages unless mentioned in the changelog (avoid re-review - I will only check diffs for the items above and upload) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2166409 Title: [SRU] Please backport golang-1.25 (1.25.12) and golang-1.26 (1.26.7) to resolute, noble and jammy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-1.25/+bug/2166409/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
