Hey Ponnuvel, thanks for the patch. A few non-critical suggestions: - We could move the commit URL into Origin and drop the Applied-Upstream line, e.g. Origin: upstream, https://cgit.git.savannah.nongnu.org/cgit/dmidecode.git/commit/?id=566922aed8f865553aac053bbc43a9a1d3e3594a so a single Origin line covers it instead of two. - The patch filename could be something like lp2148318-SHORT_DESC.patch to be self-explanatory. - You might also push these as a Merge Proposal — easier for the SRU team to review, and a bit less back-and-forth.
Thanks! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2148318 Title: [SRU] dmidecode: add support for E1.S and E3.S form factors To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/dmidecode/+bug/2148318/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
