Took another look at this during my current patch-pilot shift. Thanks for making the adjustments: I see the PPA building successfully against all archs now (including amd64v3 and riscv64, which is nice to see). Things that still need addressing at this point:
1. The changelog for a new package typically includes one entry indicating this is the initial upload for Ubuntu. Admittedly, in this case that does mean losing a lot of "history" in the changelog, but it's not history that ever occurred to the package in Ubuntu and thus can confuse users if it's present. 2. The changelog needs to target stonking as that's where the package will be uploaded. If there's a different version of vulkan for stonking that would also require the package to be updated. 3. I note the debian/patches haven't been forwarded upstream. In the case of the JsonCpp patch, the rationale sounds reasonable for it being "not-needed". However, in add-so-versioning-for-correct-install.patch (incidentally that's a bit of a mouthful -- maybe just add-so- versioning.patch?), the rationale seems thin. Yes, the patch is only required for building but it still sounds like it might be useful to others upstream and thus is probably worth forwarding. 4. The construction of the version number with a 0ubuntuX suffix is good (and required when there's no Debian package upstream of us). Don't worry about the ~ppa1 suffix for now -- that can be stripped off once everything else is dealt with. For the convenience of future reviewers: * I've checked the WNPP bug up in Debian and can't see any potential clashes there with vulkan-profiles. * Build is lintian-clean (with pedantic) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2129955 Title: [needs-packaging] vulkan-profiles To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/2129955/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
