Public bug reported:
[ Impact ]
* rocm-cmake 7.2.3 contains two functional fixes to the CMake build tooling
modules shipped by this package:
1. Lintian-clean CPack packaging scripts (ROCMCreatePackage.cmake, #273) —
rocm_create_package() unconditionally registered empty postinst/prerm
shell scripts with CPack (CPACK_DEBIAN_PACKAGE_CONTROL_EXTRA,
CPACK_RPM_POST_INSTALL_SCRIPT_FILE, CPACK_RPM_PRE_UNINSTALL_SCRIPT_FILE),
causing Lintian to emit warnings about empty maintainer scripts in
packages built by downstream ROCm consumers. The new
rocm_check_and_configure_script_files() helper checks file size before
registering each script, so empty scripts are silently omitted.
2. Long-pathname support in clang-tidy targets (ROCMClangTidy.cmake, #279) —
rocm_clang_tidy_check() derived per-source tidy target names via
string(MAKE_C_IDENTIFIER) applied to the full absolute source path. On
build trees with deep paths (e.g. RPM debug-info packaging paths), this
produced CMake target names that exceeded filesystem limits, causing
clang-tidy cache .cmake files to fail to write. The fix derives the
target name from the relative path under the source or binary root,
prefixed with "s/" or "b/" to distinguish them. The clang-tidy cache
pre-processing output parsing is also made robust to verbose compiler
output by using a regex match before the string replace.
ROCMCppCheck.cmake has a minor escaping fix for the GitHub Annotations
template string (triple backslash corrected to double).
* This upload also includes a packaging fix to debian/tests/upstream-tests:
the autopkgtest runner patched out rocm-cmake's self-install step (using
the system package instead) but did not create the ${PREFIX} directory
that simple-test-package.cmake needs as an extraction target. The sed
substitution now emits a file(MAKE_DIRECTORY) call in place of the skipped
install_dir(), ensuring the directory exists before the tar extraction step.
[ Test Plan ]
1. Build:
- sbuild or dpkg-buildpackage succeeds.
- dpkg --compare-versions 7.2.3-0ubuntu1 gt 7.1.1-0ubuntu1 returns true.
- No debian/symbols file exists for this package (CMake modules only,
no shared libraries).
2. Installability:
- apt install rocm-cmake succeeds.
- Confirm reverse dependencies remain installable without rebuild.
3. Autopkgtest:
- Run autopkgtest suite (cmake-find-package, build-simple-library,
upstream-tests).
- All tests pass. Output from resolute/amd64 run against
ppa:igorluppi/rocm-cmake-7.2.3:
autopkgtest [13:32:13]: test cmake-find-package: - - - - - - - - - -
results - - - - - - - - - -
cmake-find-package PASS (superficial)
autopkgtest [13:32:19]: test build-simple-library: - - - - - - - - - -
results - - - - - - - - - -
build-simple-library PASS
autopkgtest [14:24:03]: test upstream-tests: - - - - - - - - - - results
- - - - - - - - - -
upstream-tests PASS
autopkgtest [14:24:03]: @@@@@@@@@@@@@@@@@@@@ summary
cmake-find-package PASS (superficial)
build-simple-library PASS
upstream-tests PASS
[ Where problems could occur ]
1. Downstream consumers using rocm_create_package() with no ldconfig — those
packages previously always shipped an empty prerm/postinst; they will now
omit them. No behavioural difference is expected for end-user installs.
Packages calling rocm_create_package(LDCONFIG ...) are unaffected (the
scripts remain non-empty and are still included).
2. Clang-tidy target name change — any downstream project that referenced
tidy-target-<TARGET>-<old-mangled-name> by name in custom CMake code will
need to update to the new relative-path-based names. This affects only
downstream CMake project developers, not end-user binary installs.
[ Other Info ]
* No .symbols file: rocm-cmake ships CMake modules only; there are no shared
libraries or ELF symbols to track.
* This update is part of the coordinated ROCm 7.2.3 stack release.
* PPA: https://launchpad.net/~igorluppi/+archive/ubuntu/rocm-cmake-7.2.3
* Upstream version comparison:
https://github.com/ROCm/rocm-cmake/compare/rocm-7.1.1...rocm-7.2.3
* target: resolute
** Affects: rocm-cmake (Ubuntu)
Importance: Undecided
Assignee: Igor Luppi (igorluppi)
Status: In Progress
** Changed in: rocm-cmake (Ubuntu)
Assignee: (unassigned) => Igor Luppi (igorluppi)
** Changed in: rocm-cmake (Ubuntu)
Status: New => In Progress
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2153804
Title:
SRU: New upstream version 7.2.3
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/rocm-cmake/+bug/2153804/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
