This seems reasonable and I'll accept into proposed. However, I think
the regression analysis and test plan need some work. I'm terrified of
inadvertently breaking nftables generally for all users such that they
cannot receive a future update, so that's a pretty serious "Where
problems could occur" for any nftables SRU really. Fortunately the patch
seems straightforward.

Maybe enhance the Test Plan please to ensure that nftables still works
as expected in a regular scenario, as well as specifically looking for
the crash as you're doing?

If you have confidence that the patch is itself trivial some analysis of
that would be helpful too - for example is it a rare code path? Is it
possible that the early return you're adding catches too much and will
break some user, or if not how are you confident that's the case?

** Changed in: nftables (Ubuntu Noble)
       Status: Triaged => Fix Committed

** Tags added: verification-needed verification-needed-noble

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2142552

Title:
  netlink: fix crash when ops doesn't support udata

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/nftables/+bug/2142552/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to