I had a first look at the package (taken from the PPA) and found a few things / have a few questions, listing them here:
- d/copyright file looks great - d/watch is good (is already a v5) - d/rules looks reasonable - d/s/format is ok - maintainer in d/control is ok (there is a hint about dpkg-parsechangelog, but not urgently needed, would req. modifications to make file) - "W: rocm-core source: source-contains-quilt-control-dir [.pc/]" rm -rf .pc tar tf ../rocm-core_7.1.0-0ubuntu1~git202601311301.ef5db1a~ubuntu26.04.1.tar.xz | grep "\.pc" rocm-core-7.1.0/.pc/ rocm-core-7.1.0/.pc/.quilt_patches rocm-core-7.1.0/.pc/.quilt_series rocm-core-7.1.0/.pc/.version rocm-core-7.1.0/.pc/0001-add-option-to-disable-cpack.patch/ rocm-core-7.1.0/.pc/0001-add-option-to-disable-cpack.patch/.timestamp rocm-core-7.1.0/.pc/0001-add-option-to-disable-cpack.patch/CMakeLists.txt rocm-core-7.1.0/.pc/0002-add-compile-time-warning-for-rocm-core-version.patch/ rocm-core-7.1.0/.pc/0002-add-compile-time-warning-for-rocm-core-version.patch/.timestamp rocm-core-7.1.0/.pc/0002-add-compile-time-warning-for-rocm-core-version.patch/rocm_version.h.in rocm-core-7.1.0/.pc/applied-patches What is with these patches ? Are these patches still needed ? If so they are supposed to be in debian/patches/ - incl. a series file. There must not be a ".pc" folder in the src package folder nor in the origi tar-ball, since the ".pc" folder is a temporary folder used by quilt. - I could find a postinst and prerm script in the top level src folder, but they belong to the debian/ folder. - "W: rocm-core source: upstream-metadata-in-native-source [debian/upstream/metadata]" I think this package is not a Debian native package. Debian native packages usually have debian/upstream/metadata. In this case I think this file needs to be removed to suppress lintian tag "upstream-metadata-in-native-source". The upstream project can also be found via the 2nd line in d/copyright. - Does the package version really needs to be like this "7.1.0-0ubuntu1~git202601311301.ef5db1a~ubuntu26.04.1"? Since this triggeres quite a bunch of warnings. (https://documentation.ubuntu.com/project/how-ubuntu-is-made/concepts/version-strings/) - latest d/changelog entry needs some clean-up: "rocm-core (7.1.0-0ubuntu1~git202601311301.ef5db1a~ubuntu26.04.1) resolute; urgency=low * Auto build. -- Launchpad Package Builder <[email protected]> Sat, 31 Jan 2026 13:01:10 +0000 " - I think "Auto build" is not sufficient. - No LP bug referenced - needs to be referenced as a bullet with "LP: #1234567" or "(LP: #1234567)". - Not a proper,valid email address, name and date in signature line 5. - The "librocm-core1.symbols" looks very short (just 5 lines), but according to the build log that's correct. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2139350 Title: [needs-packaging] rocm-core - Lets have it in Ubuntu! To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/2139350/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
