In the last patch, there is the following:

+               if err != nil {
+                       if resp != nil {
+                               if virus := 
resp.Header.Get("X-Virus-Infected"); virus != "" {
+                                       err = fmt.Errorf("server reports this 
file is infected with a virus - use --onedrive-av-override to download anyway: 
%s: %w", virus, err)
+                               }
+                       }
+                       return nil, err
+               }

There is a slight issue with this: the rclone versions in plucky and
noble do not contain the commit[1] that introduced the --onedrive-av-
override logic.

This means that (a) rclone could start telling users about a flag that
does not exist (which would be a UX regression), and (b) this patch is
not quite "minimal" for fixing this bug (it should not include the logic
for handling X-Virus-Infected header).

For point (a) more than anything, this needs to be fixed and re-
uploaded.

[1]
https://github.com/rclone/rclone/commit/61d6f538b36171ad189ba85ad848352f316cdc8e

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2076021

Title:
  Rclone on Ubuntu 22.04 is unable to sync crypt remote with OneDrive
  properly

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/rclone/+bug/2076021/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to