It looks like the phone home behaviour is configurable, and defaults to
"true" in src/preferences_dialog.cpp:

ui.checkRcloneBrowserUpdates->setChecked(
      settings->value("Settings/checkRcloneBrowserUpdates", true).toBool());
ui.checkRcloneUpdates->setChecked(
      settings->value("Settings/checkRcloneUpdates", true).toBool());

I think that:

1) We could change those to false, and that would mean that the
behaviour is disabled by default, which is appropriate for distribution
packaging.

2) It might be appropriate to disable those settings entirely, since for
a distribution package, "checking" for updates makes no sense as it
should happen by apt instead, and the user choosing to install a
distribution package using apt is deliberately opting in to apt-based
package update management.

Does the attached patch work? I wrote it without any testing to
demonstrate how I think this would best be fixed. It should: 1) make it
impossible to enable this behaviour; 2) always treat the phone home
"setting" as "never phone home".

I'm not sure we have enough time to get this into Plucky, unfortunately,
but at least it can be properly fixed for the future.

Note: I don't consider this patch ready for upload without actual
testing. I don't intend to do that testing myself.

** Patch added: "disable-phone-home.patch"
   
https://bugs.launchpad.net/ubuntu/+source/rclone-browser/+bug/2059246/+attachment/5870479/+files/disable-phone-home.patch

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2059246

Title:
  packaged version should not check for latest release

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/rclone-browser/+bug/2059246/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to