Thank you for the review points @Robie. Re 1. The proposal for the retry on the installer was brought up with the Store team and the consensus was that given the use in our pipelines this change should be fine from the server POV. I will request someone to formally confirm/sign-off for your reference.
Re 2. This was something I should have considered carefully. With some testing on my end by reproducing the issue through what you suggested in 3 (redirecting api.snapcraft.io in /etc/hosts to simulate the unavailability of the service), I get the following observation: - The current state of lxd-installer without any retry fails to install the snap after 32.817s. - With the proposed change, this goes up to 1m43.264s due to the retries and sleeps. I can comment that on our pipelines, the timeout set for the action that triggers the installation is 'generous' enough at 240s so as to not require further work. The use of this lxd-installer elsewhere however is likely bound by a different timeout. I am of the opinion that such users would be willing to accommodate the retries at the possible benefit of allowing a successful installation where the cost is about 1 minute overhead. Could you suggest what you would prefer to see to make this point as little opinion-based as possible? Re 3. Thank you for the suggestion, I will update the bug description as a redirect in /etc/hosts is a much closer reproducer for the API unavailability. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2100564 Title: lxd-installer shim fails to install with snapstore error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/lxd-installer/+bug/2100564/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
