This seems like an appropriate fix for future releases. However, is it appropriate for SRU? Won't it change existing behaviour for existing users?
> We happened to have some devices having Mic Mute key untranslated by hwdb, typically we just add entries in hwdb to fix the issue This seems like a more appropriate solution for existing stable releases, no? > Since mic mute key is forcibly translated to F20 despite of hardware, if there's any application using that key for other features, it may be in conflict. Well, exactly. This suggests that this is inappropriate for SRU. From https://documentation.ubuntu.com/sru/en/latest/explanation/requirements/#minimal- changes-only: "In line with this, the requirements for stable updates are not necessarily the same as those in the development release. When preparing future releases, one of our goals is to construct the most elegant and maintainable system possible, and this often involves fundamental improvements to the system’s architecture, rearranging packages to avoid bundled copies of other software so that we only have to maintain it in one place, and so on. However, once we have completed a release, the priority is normally to minimise risk caused by changes not explicitly required to fix qualifying bugs, and this tends to be well-correlated with minimising the size of those changes. As such, the same bug may need to be fixed in different ways in stable and development releases." Given the above, I think you need deeper justification as to why this is the correct fix for existing stable releases. ** Changed in: xserver-xorg-input-libinput (Ubuntu Noble) Status: In Progress => Incomplete ** Changed in: xserver-xorg-input-libinput (Ubuntu Oracular) Status: In Progress => Incomplete -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2103967 Title: [SRU] Include a patch that forcibly maps mic mute key and touchpad function keys to F20-F23 To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/2103967/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
