This looks good, but a few tweaks are need to the bug description for the purposes of the SRU process. The test plan is nicely written for verifying that the bug is fixed, but for SRU purposes it needs to:
* first replicate the issue (demonstrate the issue is actually present) * upgrade the package from the proposed pocket (I realise it's not present in proposed yet, but we write the test plan from the perspective of what's going to be tested once it is) * finally, demonstrate the proposed version now fixes the issue I've edited the description to something I think should be acceptable for the SRU team, but please feel free to edit further if I've made any mistakes! The other part that needs a minor tweak is the regression section: it's fine to point out what the fix *should* be fixing, but this is more about unintended side effects. In other words, consider what the consequences could be if this update (accidentally) breaks update- manager for the user. No matter how trivial the fix, this is always a possibility. In this case, it's probably worth pointing out that, even if update- manager is broken to the point it cannot run, it's a thin veneer over the actual package management system, and the user would still have a path to upgrade packages via the apt command. ** Description changed: [Impact] If one deselects all packages, the "Install Now" button disappears, which makes sense (on another note it would make even more sense if it was simply grayed out). However when one or more packages are then re- selected, the button won't ever reappear, and update-manager must be restarted in order to upgrade any packages. [Test case] - *If 'apt list --upgradable' is empty, downgrade any one package in your system. - *ua detach --assume-yes - *apt install hello - *update-manager - -There will be at least one update available, and the hello package will be unavailable under the 'Ubuntu Pro security updates' section. - *De-select all available packages. - -The 'install now' button disappears. - *Select at least one available package. - -The 'install now' button should reappear. + For each affected $series: + + * If 'apt list --upgradable' is empty, downgrade any one package in your system. + * sudo ua detach --assume-yes + * sudo apt install hello + * update-manager + * Verify at least one update is available, and the hello package is unavailable under the 'Ubuntu Pro security updates' section + * De-select all available packages + * Verify the 'install now' button disappears + * Select at least one available package + * Verify the 'install now' button is still absent + * Close the window + + * Enable proposed (see https://wiki.ubuntu.com/Testing/EnableProposed) + * sudo apt install -t $series-proposed update-manager + + * update-manager + * Verify at least one update is available, and the hello package is unavailable under the 'Ubuntu Pro security updates' section + * De-select all available packages + * Verify the 'install now' button disappears + * Select at least one available package + * Verify the 'install now' button is now visible again [Where things could go wrong] Things could go wrong with the 'install now' button. It should be visible when there is any available package selected and not visible when there is none selected. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2068805 Title: [SRU] "Install Now" button disappears for good if all packages unselected and Ubuntu Pro packages are shown but unavailable To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/2068805/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
