Hey Matthieu, thanks for the patch! The patch itself looks good, but I have some comments on the changelog. :)
Firstly, I'm noticing this: "Closes LP: #2071412." Technically it's correct, since it matches the LP bug regex, but it's worth clarifying that "Closes" is a specific identifier for Debian bugs. For example, if I wanted to close https://bugs.debian.org/cgi- bin/bugreport.cgi?bug=1081636 (which does need to be closed, by the way ;) ), I would write "(Closes: #1081636)." To prevent ambiguity, I've removed "Closes" from that line. Also, the first two lines of the changelog should be consolidated. I'll keep it as this so as to not alter your words, just the spacing: + * Merge with Debian unstable (LP: #2098425). Remaining change: Here's what I've ended up with: * Merge with Debian unstable (LP: #2098425). Remaining change: - debian/patches/fix-buffer-overflow.patch: avoid possible buffer overflows (LP: #2071412). None of this is blocking, so I've uploaded this now! 🎉 Thank you for your contribution! I really appreciate all the merges! :) ** Bug watch added: Debian Bug tracker #1081636 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1081636 ** Changed in: aevol (Ubuntu) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2098425 Title: Please merge aevol 5.0+ds-4 from Debian unstable To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/aevol/+bug/2098425/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
