NEW review for spirv-llvm-translator-19.
TL;DR I'm just not sure if the symbols overrides is necessary.
This is a backport from oracular. The diff is:
diff --git a/debian/control b/debian/control
index d6f07f3..b6a6be7 100644
--- a/debian/control
+++ b/debian/control
@@ -8,7 +8,7 @@ Uploaders:
Build-Depends: debhelper-compat (= 13),
dh-sequence-pkgkde-symbolshelper,
cmake,
- gcc (>= 4:14),
+ gcc (>= 4:13),
pkgconf,
spirv-headers (>= 1.6.1+1.3.275.0),
spirv-tools,
diff --git a/debian/rules b/debian/rules
index b561e76..8f5dc67 100755
--- a/debian/rules
+++ b/debian/rules
@@ -21,6 +21,9 @@ override_dh_auto_configure:
execute_after_dh_auto_install:
mv debian/tmp/usr/bin/llvm-spirv
debian/tmp/usr/bin/llvm-spirv-$(LLVM_VERSION)
+override_dh_makeshlibs:
+ dh_makeshlibs -- -c0
+
# skip tests on big-endian architectures, uses excessive amount (> 40GB) of
disk space
ignore_test_failures = $(if $(filter $(DEB_HOST_ARCH),amd64),,-)
override_dh_auto_test:
a) d/rules: ok
b) symbols overrides
I tried the build without it, and it also succeeded, and produced the same
"noise". Why do we want "-c0", aka, "never fail"?
Quick build log diff between -c1 (default) and -c0:
@@ -328,10 +328,12 @@
dh_strip -a -O--builddir=build/
5a5f2cd7171a95fe8c33ac5dde26dcee8c4b8af0
3138cce2a32f2c8211d163a77b20b0a2bdf2b5c3
- dh_makeshlibs -a -O--builddir=build/
+ debian/rules override_dh_makeshlibs
+make[1]: Entering directory
'/home/ubuntu/git/packages/spirv-llvm-translator-19/spirv-llvm-tra+dh_makeshlibs
-- -c0
dpkg-gensymbols: warning: debian/libllvmspirvlib19.1/DEBIAN/symbols doesn't
match completely d --- debian/libllvmspirvlib19.1.symbols
(libllvmspirvlib19.1_19.1.0-1~ubuntu0.24.04.1_amd64)
-+++ dpkg-gensymbolsVmaWe_ 2024-12-12 19:53:44.982660011 +0000
++++ dpkg-gensymbolsWQmle_ 2024-12-12 19:46:22.107293376 +0000
@@ -39,7 +39,7 @@
_ZN4llvm39initializeSPIRVLowerConstExprLegacyPassERNS_12PassRegistryE@Base 13
_ZN4llvm39initializeSPIRVLowerOCLBlocksLegacyPassERNS_12PassRegistryE@Base 13
@@ -702,6 +704,7 @@
(optional=templinst)_ZZNKSt7__cxx1112regex_traitsIcE16lookup_classnameIPKcEENS1_10_RegexMask
(optional=templinst)_ZZNKSt7__cxx1112regex_traitsIcE18lookup_collatenameIPKcEENS_12basic_str
(optional=templinst)_ZZNKSt8__detail11_AnyMatcherINSt7__cxx1112regex_traitsIcEELb0ELb0ELb0EE
+make[1]: Leaving directory
'/home/ubuntu/git/packages/spirv-llvm-translator-19/spirv-llvm-tran
dh_shlibdeps -a -O--builddir=build/
dpkg-shlibdeps: warning: diversions involved - output may be incorrect
diversion by libc6 from: /lib64/ld-linux-x86-64.so.2
c) d/control is missing the maintainer update, since we now have an ubuntu
suffix.
d) lintian is clean enough
W: spirv-llvm-translator-19 source: newer-standards-version 4.7.0 (current is
4.6.2)
W: llvm-spirv-19: no-manual-page [usr/bin/llvm-spirv-19]
I: spirv-llvm-translator-19 source: adopted-extended-field (in section for
source) XSBC-Original-Maintainer [debian/control:5]
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2083020
Title:
Backport packages for 24.04.2 HWE stack
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libdrm/+bug/2083020/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
