Hi Shane,
I had a look at the modification for noble aka the noble debdiff.

I couldn't debdiff-apply it the patch, got message "Hunk is shorter than 
expected".
Fortunately the changes are pretty small, so I created one myself and figured 
out that (somehow) just a trailing blank line was missing ;-)

Just the version that you used "1.0.15468.25-2ubuntu1" is not correct.
Since we are coming from a Debian version "1.0.15468.25-2build1"
and then moving to an Ubuntu specific version, the ubuntu suffix need to start 
with "ubuntu0.1",
so "1.0.15468.25-2ubuntu0.1" for an SRU.
(according to 
https://wiki.ubuntu.com/SecurityTeam/UpdatePreparation#Update_the_packaging or
https://github.com/canonical/ubuntu-maintainers-handbook/blob/main/VersionStrings.md
 - even if lintian
might moan with "changelog-file-missing-explicit-entry 1.0.15468.25-2build1 -> 
1.0.15468.25-2ubuntu0 (missing) -> 1.0.15468.25-2ubuntu0.1").
I quickly adjusted the version.

And surprisingly the "update-maintainer" script does not need to be executed,
since d/control already has:
"
Maintainer: Ubuntu Developers <ubuntu-devel-disc...@lists.ubuntu.com>
XSBC-Original-Maintainer: Debian OpenCL team 
<pkg-opencl-de...@lists.alioth.debian.org>
"
(but as Debian version I would have expected the XSBC-Original-Maintainer as 
Maintainer - anyway ...)

I also did a successful PPA test build with -proposed enabled (I know it's a 
simple change, but one never knows...)
https://launchpad.net/~fheimes/+archive/ubuntu/lp2085370

With that I completed the review and I'm sponsoring and uploading the updated 
package to the 'noble' queue.
Check the noble queue: 
https://launchpad.net/ubuntu/noble/+queue?queue_state=1&queue_text=intel-graphics-compiler

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2085370

Title:
  Important build flag left out of IGC build

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/intel-graphics-compiler/+bug/2085370/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to