I've gone through the updated version of the package in @vpa1977's PPA and it looks like all the points raised in the first review have now been addressed. I *would* be happy to sponsor it at this point, but for one thing that's worrying me: the maintainer scripts.
The preinst/postrm script unconditionally removes "/etc/systemd/system/ModemManager.service.d/pwl-mm-suspend-resume- options.conf". I know this was suggested by the first review, but here's why this makes me nervous: Firstly, this package is a new package. It cannot previously have existed on the user's machine, so if it's removing a file it's one necessarily either not owned at all, or owned by another package. Does this indicate a potential conflict with another package? Should this only happen on certain versions of something else? Secondly, the removal happens on *every* invocation of the maintscripts, *even those involved in error recovery*. In other words, if the user goes to install this package and something goes wrong, preinst will potentially be called with abort-install (or abort-upgrade with future versions), and will remove the file even though the package install/upgrade is in the process of being aborted. Normally, dpkg-maintscript-helper would be the way to "properly" handle removal of extraneous conffiles. However, that won't work here because the file in question cannot be owned by this packaage (and dpkg- maintscript-helper won't operate on files not owned by the package being installed / upgraded). What I'd like to see to resolve this: 1. An (potentially brief) explanation of why this file needs removal, especially considering it can't be a file owned by this package 2. A consideration of a non-destructive means; could it just be renamed? 3. If it can't just be renamed, a consideration of what should be done in the abort-install/upgrade case Other than that I can't see any other issues with this, and if the above can be resolved, I'd be happy to sponsor this for upload. In the meantime, I'll remove ubuntu-sponsors pending resolution -- please do re-subscribe ubuntu-sponsors when the above point is addressed. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2084776 Title: [needs-packaging] pwl-pc-services: Support for Palcom Wireless WWAN modules To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/2084776/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
