Hi Mate, Thanks for the work on this, and verifying with Julian's script.
In the future, please include further details (e.g., in this case there are two scripts, without a mention of which was used, although it seems likely dwprod.py) and version tested (surprisingly, there are cases where people test from PPAs, not -proposed), as in the SRU docs [1]: """ Note that we require that the package as built in -proposed be tested, and verifications should include evidence that this has happened (typically by including the version number of the package tested). """ If at all possible comment on all stages of the Test Plan (e.g., in this case, the autopkgtest results for all archs, which are OK for all supported archs, except riscv64, which is not run for). Also, in this particular instance, it would be nice to include in the verification comment a note about ppc64el/s390x since those are expected to be different. Last, but not least, it turns out the impacted (non-python) code in this (python) module are some extension modules. It would be helpful to confirm whether selftests.py actually get to exercise those. (From some level of research here, it seems to do it at least with two extension modules.) I also noticed this change turns out to enable not only hardening flags, but LTO too. This doesn't seem to be a big problem as the package (extension modules) seem to continue to work, based on the paragraph above / autopkgtests exercising those. This seems to be the key point to verify with regards to checking for regressions, so it would seem like everything is in order. Nonetheless, I'll ask you to double check the next comment, and flip the verification back to done if you can confirm everything looks reasonable for release. [1] https://canonical-sru-docs.readthedocs- hosted.com/en/latest/explanation/standard-processes/#standard-processes -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2084457 Title: [SRU] Please enable frame-pointer on Noble To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/pillow/+bug/2084457/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
