Hello Seth ,

Please find my update based on your comment:

>> I see comment #5 had required and recommended todos.
Changes required from Lenovo side has been addressed and i think other concern 
from Canonical side has been fixed by AppArmor fix . Anything else needed ?


>> Comment #7 said that some issues had been fixed in a given tagged release, 
>> but not a list of what specifically had been fixed,
I had already sent e-mail to Canonical regarding fix and also you can check 
changelog https://github.com/lenovo/lenovo-wwan-unlock/releases/tag/v2.1.2 . 
Below issue is fixed as per comments:
- Moved all library in /opt/fcc_lenovo/lib folder

>>Comment #16 demonstrated the risks of changes to software that we can't see 
I think this should be covered by @binli and this is already fixed by him as 
per comment #17

>>comment #17 included a mangled diff that doesn't quite show what was added, 
>>removed, or context
Not sure , what is exepcted here from Canonical side .
@binli - All your changes are already merged 
https://github.com/lenovo/lenovo-wwan-unlock/commit/4f8e19e6f7d324decc0842e947dab2ad2bca556d

>> This is fine pre-release, we've all got things to do, but post-release it 
>> would be troubling. So I feel I should ask about it now, will these be found 
>> sooner over the next twelve to twenty years?
I can understand this concern but to avoid this , we should test it properly 
using OEM image .
Already we have tested package from main branch and released it few months back 
and didnot receive any major concern till now for Thames and Mersey .

Thanks

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2058192

Title:
  [MIR] lenovo-wwan-unlock

To manage notifications about this bug go to:
https://bugs.launchpad.net/oem-priority/+bug/2058192/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to