Initially I thought it was only about adding some sort of "alias", such
that `ubuntu_pro` would also be recognized alongside `ubuntu_advantage`.
But when looking at the diff, I see that it's actually replacing one
cloud-init module with another. I see this was also hinted at in the
"where problems could occurr" section of the bug description.
My concerns with this approach are as follows:
a) the test plan doesn't seem to cover all other changes brought in via the new
ubuntu_pro module. Not only new features, but also that existing ones don't
regress behavior if the module is invoked via the old key `ubuntu_advantage`.
b) this doesn't feel like a minimal fix anymore
c) on the justification part, it was said that users should be able to use the
same `ubuntu_pro` module configuration for x/b and later releases. But
cloud-init SRUs for x/b are no longer being done. What if focal, for example,
fixes a bug in the ubuntu_pro module there, would that also be backported to
x/b from now on?
d) since this is replacing one module with another, it's very difficult to
review the change. What else is the ubuntu_pro module bringing down? How can we
be sure it's not changing behavior, specially if being invoked by the (now
deprecated) `ubuntu_advantage` key?
e) this x/b SRU will require new images to be built for those releases, outside
of ESM. In internal conversations, that seems it's doable, but has there been a
formal agreement that it will be done for this SRU? And, considering point (c)
above, what about future SRUs?
Is the "users can now use the exact same cloud-init config all the way
from x to noble" really true, or would it just apply to Pro
configuration? Note that bionic and xenial have very different cloud-
init versions:
xenial: 21.1-19-gbad84ad4
bionic: 23.1.2
focal and later: 24.2 (with 24.3.1 in proposed)
Considering all of the above, do you think it's still worth to pursue this SRU?
** Changed in: cloud-init (Ubuntu Bionic)
Status: New => Incomplete
** Changed in: cloud-init (Ubuntu Xenial)
Status: New => Incomplete
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2067660
Title:
deprecate ubuntu_advantage config key from user-data in favor of
ubuntu_pro
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cloud-init/+bug/2067660/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
