SRU review:

1) debian/patches/egl-wayland-retrieve-DRM-device-name-before-
acquiring-.patch is being modified for no good reason (at least, it
isn't documented) and the dep3 headers are being dropped. Please explain
or fix.

2) Not essential, but the expected package version string would be
1:1.1.9-1.1ubuntu0.1. What you have provided will work but is not our
convention. If re-uploading to fix the above, please use that
opportunity to fix, but it's not necessary to re-upload just for this.

The fix itself looks fine, but I have one query on testing:

> A possible regression would be that the driver starts reporting as
incompatible on NVIDIA single-GPU systems too. One would notice by all
wayland-native applications suddenly being very slow. Note that such
systems would not default to Wayland in Jammy.

Please add to the Test Plan to verify this scenario. In general I'm
concerned about regressing non-NVIDIA systems:

>  * The scope of the change is limited to the NVIDIA proprietary
drivers.

How can we be sure that this is the case? For example, does this package
have limited scope? Is the code being changed protected from affecting
non-NVIDIA systems somehow?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1965563

Title:
  GNOME apps crash with "Protocol error" in NVIDIA Wayland sessions

To manage notifications about this bug go to:
https://bugs.launchpad.net/egl-wayland/+bug/1965563/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to