** Description changed: + [Impact] + + systemd may incorrectly mark units as needing a daemon reload, therefore + unnecessarily printing the warning that a daemon-reload is needed for + the changes to take effect. This is misleading to users, and + particularly visible in cases like running apt update, since there is an + apt hook (/etc/apt/apt.conf.d/20apt-esm-hook.conf) that starts two + systemd services. + + [Test Plan] + + This bug can be triggered by running systemctl enable/disable on a non-existent unit. After that, calling systemctl start/status/etc. will show a false warning + that the unit changed on disk. Hence, to test, simply: + + $ systemctl enable somethingthatdefinitelydoesnotexist.service + $ systemctl status systemd-resolved.service + $ apt update + + On an effected system, warnings will be shown when calling both commands + after the "enable non-existent unit" step. + + [Where problems could occur] + + This patch fixes a previous commit by ensuring that the + manager->unit_file_state_outdated flag is set *only* when some + modifications succeeded, but the overall operation failed. In cases + where everything fails, it is not necessary to set the flag. + + Since the patch is restricted to this area, any regressions from this + patch would most likely also be related to the NeedDaemonReload property + of units. + + [Other information] + + The patch is from upstream: + https://github.com/systemd/systemd/pull/32610/commits/d69cba3bfffc7b1e3197e2a34b459db13b1e1cb7#diff-84bbf3361da4139a5620a035ebd24f50a0e4d4ece7952dc2d8b4325e6ebdf6e0L2320 + + [Original Description] + I recently started seeing the following warning messages when I run `apt update`. $ sudo apt update Warning: The unit file, source configuration file or drop-ins of apt-news.service changed on disk. Run 'systemctl daemon-reload' to reload units. Warning: The unit file, source configuration file or drop-ins of esm-cache.service changed on disk. Run 'systemctl daemon-reload' to reload units. ... apt-news.service for example is in /lib/systemd/system/apt-news.service and it's a static file managed by the package. Does the package maintenance script call systemd related hooks to reload the config whenever the package gets updated? $ systemctl cat apt-news.service # /usr/lib/systemd/system/apt-news.service # APT News is hosted at https://motd.ubuntu.com/aptnews.json and can include # timely information related to apt updates available to your system. ... $ dpkg -S /lib/systemd/system/apt-news.service ubuntu-pro-client: /lib/systemd/system/apt-news.service ProblemType: BugDistroRelease: Ubuntu 24.04 Package: ubuntu-pro-client 31.1 ProcVersionSignature: Ubuntu 6.6.0-14.14-generic 6.6.3 Uname: Linux 6.6.0-14-generic x86_64 NonfreeKernelModules: zfs ApportVersion: 2.28.0-0ubuntu1 Architecture: amd64 CasperMD5CheckResult: pass CurrentDesktop: ubuntu:GNOME Date: Wed Feb 28 13:06:35 2024 InstallationDate: Installed on 2024-01-08 (51 days ago) InstallationMedia: Ubuntu 24.04 LTS "Noble Numbat" - Daily amd64 (20240104) ProcEnviron: LANG=en_US.UTF-8 PATH=(custom, no user) SHELL=/bin/bash TERM=xterm-256color XDG_RUNTIME_DIR=<set>SourcePackage: ubuntu-advantage-tools UpgradeStatus: No upgrade log present (probably fresh install) apparmor_logs.txt: cloud-id.txt-error: Failed running command 'cloud-id' [exit(2)]. Message: REDACTED config part /etc/cloud/cloud.cfg.d/99-installer.cfg, insufficient permissions REDACTED config part /etc/cloud/cloud.cfg.d/90-installer-network.cfg, insufficient permissions REDACTED config part /etc/cloud/cloud.cfg.d/99-installer.cfg, insufficient permissions REDACTED config part /etc/cloud/cloud.cfg.d/90-installer-network.cfg, insufficient permissions livepatch-status.txt-error: Invalid command specified '/snap/bin/canonical-livepatch status'. uaclient.conf: contract_url: https://contracts.canonical.com log_level: debug
-- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2055239 Title: Warning: The unit file, source configuration file or drop-ins of {apt- news,esm-cache}.service changed on disk. Run 'systemctl daemon-reload' to reload units. To manage notifications about this bug go to: https://bugs.launchpad.net/snapd/+bug/2055239/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
