Review for Source Package: highway
[Summary]
highway (libhwy) is a SIMD optimization library, implementing algorithms for
efficient, parallel operations in multiple domains, such as image processing,
compression, video analysis, sorting, cryptography... It is well maintained and
well tested. A primary usecase is its usage in jpeg-xl (libjxl).
MIR team ACK
This does need a security review, so I'll assign ubuntu-security
List of specific binary packages to be promoted to main: libhwy1t64
Specific binary packages built, but NOT to be promoted to main: <None>
Notes:
#0 - This looks good overall on security topics, but it can be used for
acceleration of cryptographic operations, so I rather like to have the
security team skim through it.
Required TODOs: <None>
Recommended TODOs:
#1 - The package should get a team bug subscriber before being promoted
#2 - consider improving the .symbols file,
"symbols-file-contains-debian-revision"
=> see "Packaging red flags" below
#3 - Please fix the autopkgtest on armhf (but I consider this normal
proposed-migration, i.e. ongoing maintenance work by the owning team,
therefore non-blocking for the MIR)
[Rationale, Duplication and Ownership]
- There is no other package in main providing the same functionality.
- A team is committed to own long term maintenance of this package.
- The rationale given in the report seems valid and useful for Ubuntu
[Dependencies]
OK:
- no other Dependencies to MIR due to this
- SRCPKG checked with `check-mir`
- all dependencies can be found in `seeded-in-ubuntu` (already in main)
- none of the (potentially auto-generated) dependencies (Depends
and Recommends) that are present after build are not in main
- no -dev/-debug/-doc packages that need exclusion
- No dependencies in main that are only superficially tested requiring
more tests now.
Problems: None
[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking
- does not have unexpected Built-Using entries
- not a go package, no extra constraints to consider in that regard
- not a rust package, no extra constraints to consider in that regard
Problems:
- Some additional software in hwy/contrib/, but seems to be part of the upstream
project, e.g. see:
https://opensource.googleblog.com/2022/06/Vectorized%20and%20performance%20portable%20Quicksort.html
[Security]
OK:
- history of CVEs does not look concerning
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not parse data formats from an untrusted source.
- does not expose any external endpoint (port/socket/... or similar)
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
- does not deal with security attestation (secure boot, tpm, signatures)
- makes appropriate use of established risk mitigation features
Problems:
- can deal with cryptography SIMD acceleration
[Common blockers]
OK:
- does not FTBFS currently
- does have a test suite that runs at build time
- test suite fails will fail the build upon error.
- does have a non-trivial test suite that runs as autopkgtest
- This does not need special HW for build or test
- no new python2 dependency
Problems:
- autopkgtest failure on armhf
[Packaging red flags]
OK:
- Ubuntu does carry a delta, but it is reasonable and maintenance under
control (Closes: #1076436)
- symbols tracking is in place.
- debian/watch is present and looks ok (if needed, e.g. non-native)
- Upstream update history is good
- Debian/Ubuntu update history is good
- the current release is packaged
- promoting this does not seem to cause issues for MOTUs that so far
maintained the package
- no massive Lintian warnings
- debian/rules is rather clean
- It is not on the lto-disabled list
Problems:
- lintian warning about
https://udd.debian.org/lintian-tag.cgi?tag=symbols-file-contains-debian-revision
=> consider improving the .symbols file,
https://wiki.debian.org/UsingSymbolsFiles#C.2B-.2B-_libraries
[Upstream red flags]
OK:
- no Errors/warnings during the build
- no incautious use of malloc/sprintf (as far as we can check it)
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside tests)
- no use of user nobody
- no use of setuid / setgid
- no important open bugs (crashers, etc) in Debian or Ubuntu
- no dependency on webkit, qtwebkit or libseed
- not part of the UI for extra checks
- no translation present, but none needed for this case (user visible)?
Problems: None
** Changed in: highway (Ubuntu)
Assignee: Lukas Märdian (slyon) => Ubuntu Security Team (ubuntu-security)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2070807
Title:
[MIR] highway
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/highway/+bug/2070807/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
