Hi Ed and Chengen, Ed, thanks for your review and feedback.
> I think that to make this patch really same some guardrails should be put in place. > it might have been safer to make this an optional feature, defaulting to disabled This also aligns with Dan's feedback (internal): > there are significant changes in behavior that are not protected by an opt-in > flag. > In fact, there is no opt-out mechanism either. So, probably the next steps would be to modify the patch to include an opt-in flag, and make the behavior change disabled by default. Chengen, is this something you could look at? The quantity and structure of the code changes in this patch might make this more difficult and require higher-touch, but hopefully it should be possible -- and if you would like any assistance, please let me know. You can find a more trivial example at [1]. Thanks! Mauricio [1] https://launchpadlibrarian.net/688200814/nova_2%3A21.2.4-0ubuntu2.5_2%3A21.2.4-0ubuntu2.6.diff.gz -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1969643 Title: RBD: Unable to delete a volume which has snapshot/volume children To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1969643/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
