Mauricio asked me to review the debdiff for Focal as well. This debdiff is different because he had to implement some code to synchronize the destruction of the worker threads with the free'ing of the thread pool.
I looked at the new code, analyzed it as best as I could, asked a few questions to Mauricio regarding the new environment variable being created, and finally got convinced that everything seems OK. The implementation is sound and the concept is simple: qemuStateCleanupWait acts similarly to a thread barrier and makes sure that all threads previously created by qemuProcessReconnect are able to finish before qemuStateCleanup can proceed. In a nutshell: LGTM, +1. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2059272 Title: libvirt domain is not listed/managed after libvirt restart with messages "internal error: no monitor path" and "Failed to load config for domain" To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/2059272/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
