> I did that and published
https://code.launchpad.net/~j-rivero/ubuntu/+source/lcm/+git/lcm/+ref/ubuntu/devel
Please create a merge proposal against pkg/ubuntu/devel, and there has been a
new upload to noble since you pushed. It will be easier to review in an MP.
I started a quick review, here are some notes:
- I ran uscan --download-current-version, that produced
../lcm_1.5.0+repack.orig.tar.xz. But d/changelog is expecting the name
1.5.0+repack1 (note the "1").
- d/changelog still has UNRELEASED as the ubuntu name, it should be noble
- new version should have suffix 0ubuntu1, not 0ubuntu2
- you need to run update-maintainer, to update the maintainer in d/control
- the source package still doesn't build, there is a mismatch between the git
tree and the orig tarball produced by uscan:
dpkg-source: info: local changes detected, the modified files are:
lcm/NEWS.md
lcm/docs/Doxyfile.in
lcm/docs/content/lcm-type-ref.md
lcm/docs/content/lua-api.md
lcm/docs/content/multicast-setup.md
lcm/docs/content/tutorial-c.md
lcm/docs/content/tutorial-cpp.md
lcm/docs/content/tutorial-dotnet.md
lcm/docs/content/tutorial-go.md
lcm/docs/content/tutorial-java.md
lcm/docs/content/tutorial-lua.md
lcm/docs/content/tutorial-matlab.md
lcm/docs/content/tutorial-python.md
lcm/docs/make.bat
lcm/examples/cpp/lcm_log_writer/pronto_joint_state_t.lcm
lcm/lcm-cmake/lcmUtilities.cmake
lcm/lcm-java/lcm/lcm/LCM.java
lcm/lcm-java/lcm/logging/LogPlayer.java
lcm/lcm-java/lcm/spy/Spy.java
lcm/lcm/dbg.h
lcm/lcm/windows/WinLCM.cpp
dpkg-source: info: Hint: make sure the version in debian/changelog matches the
unpacked source tree
dpkg-source: info: you can integrate the local changes with dpkg-source --commit
dpkg-source: error: aborting due to unexpected upstream changes, see
/tmp/lcm_1.5.0+repack1-0ubuntu2.diff.KA4DhE
dpkg-buildpackage: error: dpkg-source -I -i -b . subprocess returned exit
status 2
- in this commit, do you state that you verified you could to the standards
bump without any other changes? Usually when that's the case we see something
like "Bump standard to 4.6.2 (no changes needed)". Or, if there are changes
needed, in a follow-up commit, they would be grouped together in this commit:
commit 5e06aefc24b36cbbbd5d8f5a9bdd2b94ee705694
Author: Jose Luis Rivero <jriv...@osrfoundation.org>
Date: Tue Jan 23 19:33:46 2024 +0100
Bump standards to 4.6.2
- d/changelog could use some changes. You should try to group the
changes to the same file that go together, mentioning the files that you
changed. And no need to document in d/changelog that d/changelog was
updated, for example :). It's hard to mention it all here, and it will
be better in the MP when it's done.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2053256
Title:
[FFe] Update lcm to 1.5 for Noble
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lcm/+bug/2053256/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
