(In reply to :Gijs Kruitbosch from comment #74)
> Meh. r+ I guess? I'm not sure why this is "simpler", but obviously it works,
> so whatever.
Mostly because it avoids this blob of spaghetti code:
+ let sourceNotKeyEvent = !event.sourceEvent ||
event.sourceEvent.target.localName != "key";
+ let relatedToCurrent = (where == "tab" || where == "tabshifted") &&
sourceNotKeyEvent;
+ openUILinkIn(BROWSER_NEW_TAB_URL, where == "tabshifted" ? where : "tab",
+ {relatedToCurrent});
Comment 65 was just a quick suggestion to streamline the logic a bit. I
didn't say "please rewrite exactly like this to make this code awesome."
So unfortunately, I still find the above hard to read. Code where you
need to concentrate for a minute to decipher the structure is likely bad
code. (Except for well-written regular expressions. I love regular
expressions. :>)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/572074
Title:
New tabs open to the right of all existing tabs instead of opening
next to the current tab
To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/572074/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
