Ok, I had a brief look through the copyright - seems to be in order
(quite huge, but I could help myself out with a diff against ogre-1.12).
The debian/watch file works, is able to re-download and re-package the
current source (with a small remark) and fetch new versions from
upstream. The source package is lintian clean and most patches have DEB3
headers.

Generally it feels like the package is good to go, but we'll need to adjust the 
versioning. Just a few questions/remarks before I proceed further:
 * Remark re: the .orig tarball. Even though I think this is generally *fine* 
but when re-downloading (and auto-repacking) with uscan the current 2.2.5 
tarball, there are a few additional files present in the tarball in comparison 
to the tarball used in the PPA upload (there's some .hgignore, .travis.yaml 
etc. files in it). I would normally expect to get the exact same tarball 
contents from running uscan. In this case I think it's fine, but this might 
mean that the debian/copyright exclude list needs to be modified or, otherwise, 
no hand modifications done to the source please.
 * I see that in Debian new a previous version of ogre-next is staged - 
ogre-next_2.2.5+dfsg3-1. From what I can tell that version has a different set 
of binary packages (libogre-next2.2 instead of the set of libogrenext*2.2.5 
binaries). Would it be possible for you to submit -2 to Debian NEW? In case 
this gets accepted by Debian, it would be troublesome if a different set of 
binary packages was generated there.
 * Regarding that point above ^ - the binary package name numbers feel a bit 
confusing, with their description and purpose not being quite clear. Are those 
the 'final' binary package names? If so, could we expand their individual long 
descriptions to be a bit more clear on what their purpose is?
 * The version number needs fixing. 2.2.5+dfsg3-2ubuntu2 means that Debian has 
2.2.5+dfsg3-2 and we introduce an ubuntu delta on top. Since this package is 
not accepted into Debian as of yet, the version number needs to be 
2.2.5+dfsg3-0ubuntu2 (or, possibly, -0ubuntu1), with -0ubuntuX indicating 
'Debian doesn't have this yet, but Ubuntu does'. This makes it easier for us to 
switch to Debian once the package is available there as well.

Could you take a look at those? Thank you.

** Changed in: ubuntu
       Status: New => Triaged

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1960149

Title:
  Include ogre-next in Ubuntu Jammy

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+bug/1960149/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to