There are different source packages involved: - src:wireguard produces bin:wireguard-tools and is the subject of this MIR - src:wireguard-linux-compat produces bin:wireguard-dkms. It may be the same upstream source, but it's NOT the same source package as src:wireguard
I wondered if we should drop src:wireguard-linux-compat, since it only builds the dkms package, and we have wireguard in the kernel already. I reached out to apw, and he commented that in such cases, where a dkms module is merged with the kernel, we (canonical) tend to follow debian and drop the dkms when debian does. I was pointed at the existing debian bug requesting to drop the wireguard-dkms package: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=989406 It could lead to confusion, as some users might wonder if they have to install the dkms package or not, but I discussed this with the server team and the conclusion was that we can leave it where it is (universe), and only act if it starts to introduce problems. I also think we can drop the ubuntu delta, since it was just reordering the dependencies (wireguard-dkms (>= 0.0.20200121-2) | wireguard-modules (>= 0.0.20191219)). Indeed, canonical's kernel provides "wireguard- modules (= 1.0.0)", so we can list wireguard-modules first just like in debian: $ dpkg -s linux-image-generic|grep Depends Depends: linux-image-5.13.0-21-generic, linux-modules-extra-5.13.0-21-generic, linux-firmware, intel-microcode, amd64-microcode Jason, this is the DEP8 test I wanted to add to src:wireguard before I saw that src:wireguard-linux-compat had one already: https://git.launchpad.net/~ahasenack/ubuntu/+source/wireguard/tree/debian/tests/wireguard- wgquick?h=jammy-wireguard-dep8 I also copied over the one from src:wireguard-linux-compat (netns-mini), and I was wondering about moving the keygen test into the build process, since the other dep8 tests for sure call keygen anyway. In that way, we would have: - build test: keygen (using the built binary) - dep8 tests: two good tests: one using wg only, the other using wg and wg-quick. I'll go over the remaining issues and address them. Thanks for the MIR review, Lukas! ** Bug watch added: Debian Bug tracker #989406 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=989406 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1950317 Title: [MIR] Wireguard To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/wireguard/+bug/1950317/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
