One more review for Lucas coming out :-). I looked at debdiff and I have a few questions:
- IIUC you're not the author of the upstream patch, right? - Forgive my ignorance, but why is the upstream patch so big while the backported patch is really small and contained? Is it because the upstream patch contemplates several more changes than just adjusting buildah to the new runc API? - I think using "Origin: backport" instead of "Origin: upstream" would be more appropriate in this case, given that the patch needed to be manually adjusted. I built the package locally using your patch and it works. I also verified that the autopkgtests are indeed passing. I'll wait for your reply to my questions before I give my +1. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1939423 Title: Comply with API changes in runc 1.0.1 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-containers-buildah/+bug/1939423/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
