Please find the debdiff for the focal upload. My Ubuntu Budgie maintainer rights for some reason don't allow me to upload to focal. However they do allow me to upload to groovy. Not sure why.
The package tested is built and tested in our unstable PPA https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/unstable- test/+packages ** Description changed: - SRU In progress - [Impact] - The appmenu provides a in-panel global menu implementation for a number + The appmenu provides a in-panel global menu implementation for a number of desktop environments. - With QT apps such as VSCode, performing certain functions makes the + With QT apps such as VSCode, performing certain functions makes the appmenu produce a segmentation fault. Under Budgie, the panel restarts - and does cause the whole user session to be restarted. Under XFCE a dialog is displayed indicating that the appmenu has crashed. - This upload backport a series of upstream patches designated by the + This upload backport a series of upstream patches designated by the maintainer as a resolution of this issue. - This occurs with the v0.7.3 series of appmenu uploaded to focal and + This occurs with the v0.7.3 series of appmenu uploaded to focal and groovy. v0.7.6 that is included with hirsute already contains the fixes. - In addition whilst developing this patch it was found that the package + In addition whilst developing this patch it was found that the package itself FTBFS. A patch from upstream is included to resolve this issue. [Test Plan] - * If using the snap version of vscode, start vscode and observe the + * If using the snap version of vscode, start vscode and observe the menu in the panel. Click on the panel menu option. If using Budgie, observe that the panel restarts i.e. crashes. If using XFCE observe a dialog displayed indicating a crash. - * If using the deb version of vscode, start vscode and observe the menu + * If using the deb version of vscode, start vscode and observe the menu in the panel. Click on the File menu and attempt to open a folder. If using Budgie, bbserve that the panel restarts i.e. crashes. If using XFCE observe a dialog displayed indicating a crash. + * Next enable the proposed repository and install the following package: + For budgie-desktop budgie-appmenu-applet + For mate-desktop mate-applet-appmenu + For xfce-desktop xfce4-appmenu-plugin + + * Logout and login + * Repeat the vscode tests above - note this time that the panel crash actions do not occur. + * Next confirm that no additional panel instabilities occur with the following application types + Libreoffice + Gtk based game such as Aislerot (solitaire) that do have menus + CSD based apps such as GNOME Calculator that dont have global menu support + Try a broad range of apps found on your desktop menu. + + [Where problems could occur] - * Think about what the upload changes in the software. Imagine the change is - wrong or breaks something else: how would this show up? - - * It is assumed that any SRU candidate patch is well-tested before - upload and has a low overall risk of regression, but it's important - to make the effort to think about what ''could'' happen in the - event of a regression. - - * This must '''never''' be "None" or "Low", or entirely an argument as to why - your upload is low risk. - - * This both shows the SRU team that the risks have been considered, - and provides guidance to testers in regression-testing the SRU. + * Any potential issues with this upload is strictly limited to the package itself - there will be no regression in any other components since the package (per desktop) is self contained. + * As to the package itself - I suppose the worse case scenario is that not all the patches have been identified and cherry-picked and potentially there could be a further regression causing panel instability. + * To mitigate this I have carefully reviewed the commits released since 0.7.3 was released by upstream and I haven't identified any commits specifically in this area of code that has been patched. + * The worse case scenario is that the global menu for a users desktop will have to be removed by the user if any additional regressions are identified over and beyond the issues being fixed. + * Additional mitigation of the risks are the additional regression tests added to the test plan to cover a broader range to application types beyond the Qt apps crash issue being fixed. [Other Info] - - * Anything else you think is useful to include - * Anticipate questions from users, SRU, +1 maintenance, security teams and the Technical Board - * and address these questions in advance + + * N/A ---- $lsb_release -rd Description: Ubuntu 20.04.2 LTS Release: 20.04 Opening VS Code, particularly folders, causes the Vala-panel-appmenu to have segment fault on xfce4 and in the case of Budgie ends the entire user session as the budgie-panel cannot handle it. Backporting commits from 0.7.5 into the current release appears to fix the issue, I believe fossfreedom also backported another commit to aid in building the source properly. The crash log of Budgie-panel caused by vala-panel-appmenu has been attached. https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/appmenu diff patch https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/appmenu/+files/vala-panel-appmenu_0.7.3+dfsg1-2_0.7.3+dfsg1-2ubuntu1~ppa1.diff.gz More information can be found here https://github.com/UbuntuBudgie/budgie-desktop/issues/68#issuecomment-852748452 https://github.com/solus-project/budgie-desktop/issues/2112 https://gitlab.com/vala-panel-project/vala-panel-appmenu/-/issues/347 https://github.com/microsoft/vscode/issues/125012 https://gitlab.xfce.org/xfce/xfce4-panel/-/issues/498 ** Description changed: [Impact] The appmenu provides a in-panel global menu implementation for a number of desktop environments. With QT apps such as VSCode, performing certain functions makes the appmenu produce a segmentation fault. Under Budgie, the panel restarts - and does cause the whole user session to be restarted. Under XFCE a dialog is displayed indicating that the appmenu has crashed. - This upload backport a series of upstream patches designated by the - maintainer as a resolution of this issue. + This upload backports a series of upstream patches designated by the + maintainer as a resolution of this issue (https://gitlab.com/vala-panel- + project/vala-panel-appmenu/-/issues/327) This occurs with the v0.7.3 series of appmenu uploaded to focal and groovy. v0.7.6 that is included with hirsute already contains the fixes. In addition whilst developing this patch it was found that the package itself FTBFS. A patch from upstream is included to resolve this issue. [Test Plan] * If using the snap version of vscode, start vscode and observe the menu in the panel. Click on the panel menu option. If using Budgie, observe that the panel restarts i.e. crashes. If using XFCE observe a dialog displayed indicating a crash. * If using the deb version of vscode, start vscode and observe the menu in the panel. Click on the File menu and attempt to open a folder. If using Budgie, bbserve that the panel restarts i.e. crashes. If using XFCE observe a dialog displayed indicating a crash. - * Next enable the proposed repository and install the following package: - For budgie-desktop budgie-appmenu-applet - For mate-desktop mate-applet-appmenu - For xfce-desktop xfce4-appmenu-plugin + * Next enable the proposed repository and install the following package: + For budgie-desktop budgie-appmenu-applet + For mate-desktop mate-applet-appmenu + For xfce-desktop xfce4-appmenu-plugin - * Logout and login - * Repeat the vscode tests above - note this time that the panel crash actions do not occur. - * Next confirm that no additional panel instabilities occur with the following application types - Libreoffice - Gtk based game such as Aislerot (solitaire) that do have menus - CSD based apps such as GNOME Calculator that dont have global menu support - Try a broad range of apps found on your desktop menu. - + * Logout and login + * Repeat the vscode tests above - note this time that the panel crash actions do not occur. + * Next confirm that no additional panel instabilities occur with the following application types + Libreoffice + Gtk based game such as Aislerot (solitaire) that do have menus + CSD based apps such as GNOME Calculator that dont have global menu support + Try a broad range of apps found on your desktop menu. [Where problems could occur] * Any potential issues with this upload is strictly limited to the package itself - there will be no regression in any other components since the package (per desktop) is self contained. - * As to the package itself - I suppose the worse case scenario is that not all the patches have been identified and cherry-picked and potentially there could be a further regression causing panel instability. - * To mitigate this I have carefully reviewed the commits released since 0.7.3 was released by upstream and I haven't identified any commits specifically in this area of code that has been patched. - * The worse case scenario is that the global menu for a users desktop will have to be removed by the user if any additional regressions are identified over and beyond the issues being fixed. - * Additional mitigation of the risks are the additional regression tests added to the test plan to cover a broader range to application types beyond the Qt apps crash issue being fixed. + * As to the package itself - I suppose the worse case scenario is that not all the patches have been identified and cherry-picked and potentially there could be a further regression causing panel instability. + * To mitigate this I have carefully reviewed the commits released since 0.7.3 was released by upstream and I haven't identified any commits specifically in this area of code that has been patched. + * The worse case scenario is that the global menu for a users desktop will have to be removed by the user if any additional regressions are identified over and beyond the issues being fixed. + * Additional mitigation of the risks are the additional regression tests added to the test plan to cover a broader range to application types beyond the Qt apps crash issue being fixed. [Other Info] * N/A ---- $lsb_release -rd Description: Ubuntu 20.04.2 LTS Release: 20.04 Opening VS Code, particularly folders, causes the Vala-panel-appmenu to have segment fault on xfce4 and in the case of Budgie ends the entire user session as the budgie-panel cannot handle it. Backporting commits from 0.7.5 into the current release appears to fix the issue, I believe fossfreedom also backported another commit to aid in building the source properly. The crash log of Budgie-panel caused by vala-panel-appmenu has been attached. https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/appmenu diff patch https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/appmenu/+files/vala-panel-appmenu_0.7.3+dfsg1-2_0.7.3+dfsg1-2ubuntu1~ppa1.diff.gz More information can be found here https://github.com/UbuntuBudgie/budgie-desktop/issues/68#issuecomment-852748452 https://github.com/solus-project/budgie-desktop/issues/2112 https://gitlab.com/vala-panel-project/vala-panel-appmenu/-/issues/347 https://github.com/microsoft/vscode/issues/125012 https://gitlab.xfce.org/xfce/xfce4-panel/-/issues/498 ** Changed in: vala-panel-appmenu (Ubuntu Groovy) Status: Confirmed => In Progress ** Patch added: "Focal debdiff" https://bugs.launchpad.net/ubuntu/+source/vala-panel-appmenu/+bug/1930615/+attachment/5502255/+files/focal.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1930615 Title: VS Code crashes Vala Appmenu To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/vala-panel-appmenu/+bug/1930615/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
