Launchpad has imported 7 comments from the remote bug at
https://bugzilla.opensuse.org/show_bug.cgi?id=1133276.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2019-04-24T13:24:48+00:00 Martin-liska wrote:

Fails due to:

[   92s] objcopy --localize-hidden `sed -n 's/^ *\([a-zA-Z0-9_]*\);$/-G \1/p' 
libpmempool.map` ../nondebug/libpmempool/libpmempool_unscoped.o 
../nondebug/libpmempool/libpmempool_all.o
[   92s] ar rv ../nondebug/libpmempool/../libpmempool.a 
../nondebug/libpmempool/libpmempool_all.o
[   92s] ar: creating ../nondebug/libpmempool/../libpmempool.a
[   92s] a - ../nondebug/libpmempool/libpmempool_all.o
[   98s] 
/usr/lib64/gcc/x86_64-suse-linux/9/../../../../x86_64-suse-linux/bin/ld: 
pmemblk_priv_funcs.o (symbol from plugin): in function `os_badblocks_get':
[   98s] (.text+0x0): multiple definition of `os_badblocks_get'; 
../nondebug/libpmempool/badblock_linux.o (symbol from plugin):(.text+0x0): 
first defined here
[   98s] 
/usr/lib64/gcc/x86_64-suse-linux/9/../../../../x86_64-suse-linux/bin/ld: 
pmemblk_priv_funcs.o (symbol from plugin): in function `os_badblocks_get':
[   98s] (.text+0x0): multiple definition of `os_badblocks_count'; 
../nondebug/libpmempool/badblock_linux.o (symbol from plugin):(.text+0x0): 
first defined here
[   98s] 
/usr/lib64/gcc/x86_64-suse-linux/9/../../../../x86_64-suse-linux/bin/ld: 
pmemblk_priv_funcs.o (symbol from plugin): in function `os_badblocks_get':
[   98s] (.text+0x0): multiple definition of `os_badblocks_check_file'; 
../nondebug/libpmempool/badblock_linux.o (symbol from plugin):(.text+0x0): 
first defined here
[   98s] 
/usr/lib64/gcc/x86_64-suse-linux/9/../../../../x86_64-suse-linux/bin/ld: 
pmemblk_priv_funcs.o (symbol from plugin): in function `os_badblocks_get':
[   98s] (.text+0x0): multiple definition of `os_badblocks_clear'; 
../nondebug/libpmempool/badblock_linux.o (symbol from plugin):(.text+0x0): 
first defined here
[   98s] 
/usr/lib64/gcc/x86_64-suse-linux/9/../../../../x86_64-suse-linux/bin/ld: 
pmemblk_priv_funcs.o (symbol from plugin): in function `os_badblocks_get':
[   98s] (.text+0x0): multiple definition of `os_badblocks_clear_all'; 
../nondebug/libpmempool/badblock_linux.o (symbol from plugin):(.text+0x0): 
first defined here
[   98s] 
/usr/lib64/gcc/x86_64-suse-linux/9/../../../../x86_64-suse-linux/bin/ld: 
pmemblk_priv_funcs.o (symbol from plugin): in function `os_badblocks_get':
[   98s] (.text+0x0): multiple definition of `Realloc'; 
../nondebug/libpmempool/util.o (symbol from plugin):(.text+0x0): first defined 
here
[   98s] 
/usr/lib64/gcc/x86_64-suse-linux/9/../../../../x86_64-suse-linux/bin/ld: 
pmemblk_priv_funcs.o (symbol from plugin): in function `os_badblocks_get':
...

Reply at:
https://bugs.launchpad.net/ubuntu/+source/pmdk/+bug/1922031/comments/0

------------------------------------------------------------------------
On 2019-04-29T16:54:03+00:00 Marcin Ślusarz wrote:

This seems to come from the linker ignoring symbol locality.
Is there anything PMDK could do to fix this, other than renaming symbols in 
each library (which is infeasible)?

Reply at:
https://bugs.launchpad.net/ubuntu/+source/pmdk/+bug/1922031/comments/1

------------------------------------------------------------------------
On 2019-04-30T07:36:08+00:00 Martin-liska wrote:

(In reply to Marcin Ślusarz from comment #1)
> This seems to come from the linker ignoring symbol locality.
> Is there anything PMDK could do to fix this, other than renaming symbols in
> each library (which is infeasible)?

I can take a look in the future. But it's not critical to have LTO
working for such package.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/pmdk/+bug/1922031/comments/2

------------------------------------------------------------------------
On 2019-05-28T07:03:41+00:00 Nmoreychaisemartin wrote:

This is fixed in factory through disabling LTO for PMDK. Can we close
this bz?

Reply at:
https://bugs.launchpad.net/ubuntu/+source/pmdk/+bug/1922031/comments/3

------------------------------------------------------------------------
On 2019-05-28T07:52:13+00:00 Martin-liska wrote:

Please leave it open and assigned to me.
Thanks.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/pmdk/+bug/1922031/comments/4

------------------------------------------------------------------------
On 2020-03-13T13:23:54+00:00 Martin-liska wrote:

Now I see a different issue:

[   18s] cc -Wl,-z,relro -Wl,--fatal-warnings -Wl,--warn-common  
-L../nondebug/libpmempool/.. -shared 
-Wl,--version-script=libpmempool.link,-soname,libpmempool.so.1 -o 
../nondebug/libpmempool/../libpmempool.so.1.0.0 ../nondebug/libpmempool/alloc.o 
../nondebug/libpmempool/badblock_ndctl.o ../nondebug/libpmempool/badblock.o 
../nondebug/libpmempool/ctl.o ../nondebug/libpmempool/ctl_prefault.o 
../nondebug/libpmempool/ctl_sds.o ../nondebug/libpmempool/ctl_fallocate.o 
../nondebug/libpmempool/ctl_cow.o ../nondebug/libpmempool/extent_linux.o 
../nondebug/libpmempool/file.o ../nondebug/libpmempool/file_posix.o 
../nondebug/libpmempool/fs_posix.o ../nondebug/libpmempool/mmap.o 
../nondebug/libpmempool/mmap_posix.o ../nondebug/libpmempool/os_posix.o 
../nondebug/libpmempool/os_thread_posix.o 
../nondebug/libpmempool/os_dimm_ndctl.o ../nondebug/libpmempool/os_deep_linux.o 
../nondebug/libpmempool/out.o ../nondebug/libpmempool/pool_hdr.o 
../nondebug/libpmempool/rand.o ../nondebug/libpmempool/set.o 
../nondebug/libpmempool/shutdown_state.o ../nondebug/libpmempool/util.o 
../nondebug/libpmempool/util_posix.o ../nondebug/libpmempool/uuid.o 
../nondebug/libpmempool/uuid_linux.o 
../nondebug/libpmempool/os_auto_flush_linux.o 
../nondebug/libpmempool/libpmempool.o ../nondebug/libpmempool/check.o 
../nondebug/libpmempool/check_bad_blocks.o 
../nondebug/libpmempool/check_backup.o ../nondebug/libpmempool/check_btt_info.o 
../nondebug/libpmempool/check_btt_map_flog.o 
../nondebug/libpmempool/check_log.o ../nondebug/libpmempool/check_blk.o 
../nondebug/libpmempool/check_pool_hdr.o ../nondebug/libpmempool/check_sds.o 
../nondebug/libpmempool/check_util.o ../nondebug/libpmempool/check_write.o 
../nondebug/libpmempool/pool.o ../nondebug/libpmempool/replica.o 
../nondebug/libpmempool/feature.o ../nondebug/libpmempool/rpmem_common.o 
../nondebug/libpmempool/rpmem_ssh.o ../nondebug/libpmempool/rpmem_cmd.o 
../nondebug/libpmempool/rpmem_util.o ../nondebug/libpmempool/sync.o 
../nondebug/libpmempool/transform.o ../nondebug/libpmempool/rm.o 
pmemblk_priv_funcs.o   -pthread -lpmem -ldl -lndctl -ldaxctl 
[   18s] 
/usr/lib64/gcc/x86_64-suse-linux/10/../../../../x86_64-suse-linux/bin/ld: 
pmemblk_priv_funcs.o and ../nondebug/libpmempool/set.o: warning: multiple 
common of `Rpmem_persist'
[   18s] 
/usr/lib64/gcc/x86_64-suse-linux/10/../../../../x86_64-suse-linux/bin/ld: 
pmemblk_priv_funcs.o and ../nondebug/libpmempool/set.o: warning: multiple 
common of `Rpmem_remove'
[   18s] 
/usr/lib64/gcc/x86_64-suse-linux/10/../../../../x86_64-suse-linux/bin/ld: 
pmemblk_priv_funcs.o and ../nondebug/libpmempool/util.o: warning: multiple 
common of `Pagesize'
[   18s] 
/usr/lib64/gcc/x86_64-suse-linux/10/../../../../x86_64-suse-linux/bin/ld: 
pmemblk_priv_funcs.o and ../nondebug/libpmempool/set.o: warning: multiple 
common of `Rpmem_set_attr'
[   18s] 
/usr/lib64/gcc/x86_64-suse-linux/10/../../../../x86_64-suse-linux/bin/ld: 
pmemblk_priv_funcs.o and ../nondebug/libpmempool/mmap.o: warning: multiple 
common of `Mmap_no_random'
[   18s] 
/usr/lib64/gcc/x86_64-suse-linux/10/../../../../x86_64-suse-linux/bin/ld: 
pmemblk_priv_funcs.o and ../nondebug/libpmempool/util.o: warning: multiple 
common of `_Pmreorder_emit'
[   18s] 
/usr/lib64/gcc/x86_64-suse-linux/10/../../../../x86_64-suse-linux/bin/ld: 
pmemblk_priv_funcs.o and ../nondebug/libpmempool/set.o: warning: multiple 
common of `Rpmem_read'
[   18s] 
/usr/lib64/gcc/x86_64-suse-linux/10/../../../../x86_64-suse-linux/bin/ld: 
pmemblk_priv_funcs.o and ../nondebug/libpmempool/util.o: warning: multiple 
common of `_On_valgrind'
[   18s] 
/usr/lib64/gcc/x86_64-suse-linux/10/../../../../x86_64-suse-linux/bin/ld: 
pmemblk_priv_funcs.o and ../nondebug/libpmempool/util.o: warning: multiple 
common of `Mmap_align'
[   18s] 
/usr/lib64/gcc/x86_64-suse-linux/10/../../../../x86_64-suse-linux/bin/ld: 
pmemblk_priv_funcs.o and ../nondebug/libpmempool/mmap.o: warning: multiple 
common of `Mmap_hint'
[   18s] 
/usr/lib64/gcc/x86_64-suse-linux/10/../../../../x86_64-suse-linux/bin/ld: 
pmemblk_priv_funcs.o and ../nondebug/libpmempool/set.o: warning: multiple 
common of `Rpmem_deep_persist'
[   18s] 
/usr/lib64/gcc/x86_64-suse-linux/10/../../../../x86_64-suse-linux/bin/ld: 
pmemblk_priv_funcs.o and ../nondebug/libpmempool/set.o: warning: multiple 
common of `Rpmem_close'
[   18s] objcopy --localize-hidden `sed -n 's/^ *\([a-zA-Z0-9_]*\);$/-G \1/p' 
libpmempool.link` ../nondebug/libpmempool/libpmempool_unscoped.o 
../nondebug/libpmempool/libpmempool_all.o
[   18s] ar rv ../nondebug/libpmempool/../libpmempool.a 
../nondebug/libpmempool/libpmempool_all.o
[   18s] ar: creating ../nondebug/libpmempool/../libpmempool.a
[   18s] a - ../nondebug/libpmempool/libpmempool_all.o
[   18s] collect2: error: ld returned 1 exit status
[   18s] make[2]: *** [../Makefile.inc:261: 
../nondebug/libpmempool/../libpmempool.so.1.0.0] Error 1
[   18s] make[2]: Leaving directory 
'/home/abuild/rpmbuild/BUILD/pmdk-1.8/src/libpmempool'
[   18s] make[1]: *** [Makefile:173: libpmempool] Error 2
[   18s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/pmdk-1.8/src'
[   18s] make: *** [Makefile:83: all] Error 2
[   18s] error: Bad exit status from /var/tmp/rpm-tmp.UXWZDm (%build)

it's after LTO was disabled.

@Marcin: Can you please take a look?

Reply at:
https://bugs.launchpad.net/ubuntu/+source/pmdk/+bug/1922031/comments/5

------------------------------------------------------------------------
On 2020-03-13T16:49:29+00:00 Marcin Ślusarz wrote:

Still, the error seems to come from the linker ignoring symbol
visibility.

pmemblk_priv_funcs.o is created using objcopy --localize-hidden with a
list of symbols that need to be visible, but somehow linker still sees
those hidden symbols when linking everything.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/pmdk/+bug/1922031/comments/6


** Changed in: pmdk (openSUSE)
       Status: Unknown => Confirmed

** Changed in: pmdk (openSUSE)
   Importance: Unknown => Medium

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1922031

Title:
  pmdk not ready upstream for lto

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/pmdk/+bug/1922031/+subscriptions

-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to