[Summary]
Some required TODO and checks to be done. If all those are addressed (mostly
investigation), it would be a +1 from the MIR team POV.
However, as this library is parsing data, I think a security review would be
needed once all the points below are solved.
Notes:
Required TODOs:
- Check if libtiff can use another compresssion library and if so, if there are
strong intents to use deflate instead of that one.
- Investigate the patch disabling test issue (more info on the dedicated
section below)
Recommended TODOs:
- Analyse the warnings during build situation (see dedicated section as well)
[Duplication]
libdeflate is expected to be a more efficient 9z compression library. I guess
there is no way to use our existing compression library in libtiff, but can
you ensure it?
[Dependencies]
OK:
- no other Dependencies to MIR due to this
- no -dev/-debug/-doc packages that need exclusion
[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking
[Security]
OK:
- history of CVEs does not look concerning
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not open a port
- does not process arbitrary web content
does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
Problems:
- does parse data formats for compressing/decompressing them. Will need a
security review.
[Common blockers]
OK:
- does not FTBFS currently
- does have a test suite that runs at build time
- test suite fails will fail the build upon error.
- does have a simple test that runs as autopkgtest
- The package will have a team bug subscriber
- no translation present, but none needed for this case?
- not a python/go package, no extra constraints to consider in that regard
[Packaging red flags]
OK:
- Ubuntu does not carry a delta
- symbols tracking is in place
- d/watch is present and looks ok
- Upstream update history is good
- Debian/Ubuntu update history is good
- the current release is packaged
- promoting this does not seem to cause issues for MOTUs that so far
- no massive Lintian warnings
- d/rules is quite complex but rather clean
- Does not have Built-Using
Problems:
- one distro patch is named "Simplify tests" while its only effect is removing
a test. The name is misleading. The comment is also misleading "Don't run m32
tests on x86_64" while it’s removing it for all supported archs, without a
rationale why disabling it.
[Upstream red flags]
OK:
- no Errors during the build
- no incautious use of malloc/sprintf (as far as I can check it)
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH
- no use of user nobody
- no use of setuid
- no important open bugs (crashers, etc) in Debian or Ubuntu
- no dependency on webkit, qtwebkit, seed or libgoa-*
- not part of the UI for extra checks
Problems:
- quite a few warning during the build "profile count data file not found
[-Wmissing-profile]". Those warning could potentially spread to all binaries
using this build. Can you check with upstream about those?
** Changed in: libdeflate (Ubuntu Hirsute)
Assignee: Didier Roche (didrocks) => Sebastien Bacher (seb128)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1908502
Title:
[MIR] libdeflate
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libdeflate/+bug/1908502/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
