Public bug reported: golang-github-grpc-ecosystem-grpc-gateway started failing its autopkgtests when tested with golang-goprotobuf/1.4.2-0ubuntu1.
See https://autopkgtest.ubuntu.com/packages/g/golang-github-grpc- ecosystem-grpc-gateway/groovy/amd64 The specific failing test case output is: --- FAIL: TestParseRequest (0.00s) --- FAIL: TestParseRequest/Empty_input_should_produce_empty_output (0.00s) --- PASS: TestParseRequest/Invalid_reader_should_produce_error (0.00s) --- PASS: TestParseRequest/Invalid_proto_message_should_produce_error (0.00s) FAIL FAIL github.com/grpc-ecosystem/grpc-gateway/codegenerator 0.034s ? github.com/grpc-ecosystem/grpc-gateway/protoc-gen-grpc-gateway [no test files] WARNING: Package "github.com/golang/protobuf/protoc-gen-go/generator" is deprecated. A future release of golang/protobuf will delete this package, which has long been excluded from the compatibility promise. --- PASS: TestAnnotateContext_SupportsCustomAnnotators (0.00s) === RUN TestDefaultHTTPError --- FAIL: TestDefaultHTTPError (0.00s) panic: mismatching field: got github_com.grpc_ecosystem.grpc_gateway.runtime.errorBody.error, want github_com.grpc_ecosystem.grpc_gateway.runtime.errorBody.message [recovered] panic: mismatching field: got github_com.grpc_ecosystem.grpc_gateway.runtime.errorBody.error, want github_com.grpc_ecosystem.grpc_gateway.runtime.errorBody.message ... FAIL github.com/grpc-ecosystem/grpc-gateway/runtime 0.032s ? github.com/grpc-ecosystem/grpc-gateway/runtime/internal [no test files] In decyphering what all that means, it's essentially just failing this one test case: import ( ... "github.com/golang/protobuf/proto" plugin "github.com/golang/protobuf/protoc-gen-go/plugin" "github.com/grpc-ecosystem/grpc-gateway/codegenerator" ) var parseReqTests = []struct { name string in io.Reader out *plugin.CodeGeneratorRequest err error }{ { "Empty input should produce empty output", mustGetReader(&plugin.CodeGeneratorRequest{}), &plugin.CodeGeneratorRequest{}, nil, }, Which is just a "" == "" sanity check test case. The warning up above is triggered by the init of protoc-gen-go/generator by this test case, and it suggests that protoc-gen-go/generator's API does not have a stability guarantee and is deprecated for removal. My guess is that our change from golang-goprotobuf 1.3.x (currently in groovy) to golang-goprotobuf 1.4.x (currently in groovy-proposed) involves (at least) a behavioral change in this particular API that is triggering this test failure. Our golang-github-grpc-ecosystem-grpc-gateway 1.6.4 is far behind upstream. They dropped their use of protoc-gen-go/generator with their v1.14.5 release (See https://github.com/grpc-ecosystem/grpc- gateway/issues/1209, https://github.com/grpc-ecosystem/grpc- gateway/pull/1260, and https://github.com/grpc-ecosystem/grpc- gateway/releases/tag/v1.14.5) although I notice they did not update this particular test case. My guess is we can simply disable the test for now, so as to at least unblock golang-goprotobuf. ** Affects: golang-github-grpc-ecosystem-grpc-gateway (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1897179 Title: Autopkgtest failure attempting to test deprecated/removed api To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/golang-github-grpc-ecosystem-grpc-gateway/+bug/1897179/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
