Launchpad has imported 19 comments from the remote bug at https://bugzilla.mozilla.org/show_bug.cgi?id=1664607.
If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help.launchpad.net/InterBugTracking. ------------------------------------------------------------------------ On 2020-09-12T07:14:49+00:00 Landry-openbsd wrote: 78.2.1 was fine, 78.2.2 has the account wizard broken at startup, or message pane empty, etc.. in the error console this message is shown: ``` Uncaught TypeError: Cc['@mozilla.org/updates/update-manager;1'] is undefined ``` https://hg.mozilla.org/releases/comm-esr78/rev/ec20676c465e72ce5a35db0f4df995f4a508a24c#l1.78 doesnt check if the update-manager is available ? Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1895898/comments/0 ------------------------------------------------------------------------ On 2020-09-12T07:22:21+00:00 Mozilla wrote: In addition apparently the "Check for updates" button also appears even if built w/o updater: ac_add_options --disable-updater which is another regression. Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1895898/comments/1 ------------------------------------------------------------------------ On 2020-09-12T07:25:02+00:00 Mozilla wrote: wait a sec and forget my last comment for now. Did some test mistake. Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1895898/comments/2 ------------------------------------------------------------------------ On 2020-09-12T07:31:33+00:00 Landry-openbsd wrote: ``` Uncaught TypeError: Cc['@mozilla.org/updates/update-manager;1'] is undefined showWhatsNewPage chrome://messenger/content/specialTabs.js:1051 openSpecialTabsOnStartup chrome://messenger/content/specialTabs.js:799 OnLoadMessenger chrome://messenger/content/msgMail3PaneWindow.js:617 onload chrome://messenger/content/messenger.xhtml:1 ``` is the complete error message. >From my understanding, other similar callers do call `.activeUpdate` after getting the potential updatemanager component, eg https://searchfox.org/comm- esr78/source/mail/components/preferences/general.js#1484 ? or that should be withing some #ifdef updater-is-enabled ? Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1895898/comments/3 ------------------------------------------------------------------------ On 2020-09-12T07:33:04+00:00 Landry-openbsd wrote: missing check for AppConstants.MOZ_UPDATER maybe ? Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1895898/comments/4 ------------------------------------------------------------------------ On 2020-09-12T07:52:27+00:00 Landry-openbsd wrote: looking at the showWhatsNewPage() method in .1 and .2, previously there was a try/catch to gracefully handle non-existent update-manager component, which isnt the case anymore. Dunno what's the best fix for all cases, but for now adding a local hack. Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1895898/comments/5 ------------------------------------------------------------------------ On 2020-09-12T09:29:22+00:00 Vseerror wrote: like bug 1664590 ? Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1895898/comments/6 ------------------------------------------------------------------------ On 2020-09-12T09:45:49+00:00 Fkrueger-6 wrote: See also openSUSE bug at https://bugzilla.opensuse.org/show_bug.cgi?id=1176384#c0 Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1895898/comments/7 ------------------------------------------------------------------------ On 2020-09-12T15:19:45+00:00 Landry-openbsd wrote: (In reply to Wayne Mery (:wsmwk) from comment #6) > like bug 1664590 ? cant say that the exact same bug but seems similar Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1895898/comments/8 ------------------------------------------------------------------------ On 2020-09-12T17:35:16+00:00 Rob Lemley wrote: *** Bug 1664590 has been marked as a duplicate of this bug. *** Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1895898/comments/9 ------------------------------------------------------------------------ On 2020-09-12T17:52:12+00:00 Rob Lemley wrote: Created attachment 9175384 Bug 1664607 - Don't try to load what's new page when built with updater disabled. r=mkmelin When Thunderbird is built with --disable-updater, as it done by most Linux distributions, accessing the nsIUpdateManager service will throw an error resulting in a broken UI. Check AppConstants.MOZ_UPDATER when using nsIUpdateManger to prevent errors. Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1895898/comments/10 ------------------------------------------------------------------------ On 2020-09-12T17:58:00+00:00 Rob Lemley wrote: I did a local build with this patch and --disable-updater and verified that it works as intended. Try jobs at: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=b0c4a8521444fea8af25aee1f9619818a7e5b7a5 https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=aa4b9d60192ae7f1ca9f39c0cdedb7fa6c19f28a I also quickly checked to see what happens when updates are disabled via enterprise policies. In that case, activeUpdate should just return null so there should not be any problems. Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1895898/comments/11 ------------------------------------------------------------------------ On 2020-09-14T08:23:05+00:00 Mkmelin+mozilla wrote: *** Bug 1664721 has been marked as a duplicate of this bug. *** Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1895898/comments/12 ------------------------------------------------------------------------ On 2020-09-14T10:40:21+00:00 Pulsebot wrote: Pushed by mkme...@iki.fi: https://hg.mozilla.org/comm-central/rev/6379c3b860f7 Don't try to load what's new page when built with updater disabled. r=mkmelin DONTBUILD Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1895898/comments/13 ------------------------------------------------------------------------ On 2020-09-14T16:19:51+00:00 Rob Lemley wrote: Comment on attachment 9175384 Bug 1664607 - Don't try to load what's new page when built with updater disabled. r=mkmelin [Approval Request Comment] Regression caused by (bug #): 1563411 User impact if declined: This issue affects users that use various Linux distribution builds which are built with --disable-updater. The bug causes portions of the UI to not load resulting in an unusable interface. Users of "official" builds are not affected, and the fix would have no impact as it just wraps the what-new loading code in a conditional based on the value of MOZ_UPDATER which is set at build time automatically. Testing completed (on c-c, etc.): I tested local a build of esr78 with this patch and --disable-updater to make sure it works as expected. When testing beta it would be nice if QA can test with an enterprise policy that disables updates. I don't expect any issues based on reading the code, but I may have missed something. Risk to taking this patch (and alternatives if risky): I see very little risk in accepting this patch as the variable in question is always set to True on official builds and is not possible to change without a recompile. Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1895898/comments/14 ------------------------------------------------------------------------ On 2020-09-14T20:46:25+00:00 Vseerror wrote: Comment on attachment 9175384 Bug 1664607 - Don't try to load what's new page when built with updater disabled. r=mkmelin [Triage Comment] Approved for beta Approved for esr78 [Triage Comment] Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1895898/comments/15 ------------------------------------------------------------------------ On 2020-09-14T21:50:55+00:00 Rob Lemley wrote: Thunderbird 81.0b4: https://hg.mozilla.org/releases/comm-beta/rev/e272532e6010 Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1895898/comments/16 ------------------------------------------------------------------------ On 2020-09-15T22:14:45+00:00 Rob Lemley wrote: I checked an official build with enterprise policies disabled and saw no UI issues. OpenSUSE has applied this patch to their 78.2.2 build [Bug](https://bugzilla.opensuse.org/show_bug.cgi?id=1176384#c18) and [Changelog](https://build.opensuse.org/package/revisions/mozilla/thunderbird78) successfully. Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1895898/comments/17 ------------------------------------------------------------------------ On 2020-09-17T03:13:26+00:00 Rob Lemley wrote: Thunderbird 78.3.0: https://hg.mozilla.org/releases/comm-esr78/rev/f085dbd311bc Reply at: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1895898/comments/21 ** Changed in: thunderbird Status: Unknown => Fix Released ** Bug watch added: bugzilla.opensuse.org/ #1176384 https://bugzilla.opensuse.org/show_bug.cgi?id=1176384 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1895898 Title: Thunderbird 78.2.2-ubuntu does not show folders etc. To manage notifications about this bug go to: https://bugs.launchpad.net/thunderbird/+bug/1895898/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
