_rescue_includes does check if a package is already present and continues. But in a run with some debug between flaky and sorted output I found modemmanager-dev toggling between "Rescued from modemmanager" (unsorted) and "libmm-glib-dev" (sorted)
I many times see "_add_dependency modemmanager" before we get to the rescue check. And I'd assume that this makes it not rescuing it and be skipped. unsorted/germinate.log:11974: D: rescue-check modemmanager-doc unsorted/germinate.log:11975: D: Rescued modemmanager-doc from extra to supported unsorted/germinate.log:11977: D: rescue-check gir1.2-modemmanager-1.0 unsorted/germinate.log:11978: D: Rescued gir1.2-modemmanager-1.0 from extra to supported unsorted/germinate.log:11980: D: rescue-check modemmanager-dev unsorted/germinate.log:11981: D: Rescued modemmanager-dev from extra to supported unsorted/germinate.log:15661: D: rescue-check modemmanager-doc unsorted/germinate.log:15663: D: rescue-check gir1.2-modemmanager-1.0 unsorted/germinate.log:15665: D: rescue-check modemmanager-dev sorted/germinate.log:11970: D: rescue-check gir1.2-modemmanager-1.0 sorted/germinate.log:11971: D: Rescued gir1.2-modemmanager-1.0 from extra to supported sorted/germinate.log:11980: D: rescue-check modemmanager-dev sorted/germinate.log:11982: D: rescue-check modemmanager-doc sorted/germinate.log:11983: D: Rescued modemmanager-doc from extra to supported sorted/germinate.log:15658: D: rescue-check gir1.2-modemmanager-1.0 sorted/germinate.log:15664: D: rescue-check modemmanager-dev sorted/germinate.log:15666: D: rescue-check modemmanager-doc First of all we see that multiple rescue checks are done multiple times, there would be an optimization to skip duplicates here. But more interestingly if we see that in one case it already was in output._all and skipped while it wasn't in the other. Looking further we see that "libmm-glib-dev" also is a rescued dependency. And in one case it was processed earlier, in the other later. Due to that we all the time had flickering output, as the set was unsorted those that came early got the "Rescued from" entry and were added including their dependency tree. But also they were further filling output._all and due to that reducing the chance for further entries to be marked as "Rescued" -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1895106 Title: output non reproducible inhibiting verification of changes To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/germinate/+bug/1895106/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
