** Tags added: oem-priority originate-from-1880123 somerville
** Description changed:
[Impact]
Can't wake up by touching the touchpad.
[Fix]
- 1.gpio: With 'commit 461c1a7d4733 ("gpiolib: override irq_enable/disable")'
- gpiolib overrides irqchip's irq_enable and irq_disable callbacks. If
irq_disable
- callback is implemented then genirq takes unlazy path to disable irq.
Underlying irqchip
- may not want to implement irq_disable callback to lazy disable irq
- when client drivers invokes disable_irq(). By overriding irq_disable
callback,
- gpiolib ends up always unlazy disabling IRQ.
- Allow gpiolib to lazy disable IRQs by overriding irq_disable callback only
- if irqchip implemented irq_disable. In cases where irq_disable is not
- implemented irq_mask is overridden. Similarly override irq_enable callback
- only if irqchip implemented irq_enable otherwise irq_unmask is overridden.
+ 1.gpio: With 'commit 461c1a7d4733 ("gpiolib: override irq_enable/disable")'
+ gpiolib overrides irqchip's irq_enable and irq_disable callbacks. If
irq_disable
+ callback is implemented then genirq takes unlazy path to disable irq.
Underlying irqchip
+ may not want to implement irq_disable callback to lazy disable irq
+ when client drivers invokes disable_irq(). By overriding irq_disable
callback,
+ gpiolib ends up always unlazy disabling IRQ.
+ Allow gpiolib to lazy disable IRQs by overriding irq_disable callback only
+ if irqchip implemented irq_disable. In cases where irq_disable is not
+ implemented irq_mask is overridden. Similarly override irq_enable callback
+ only if irqchip implemented irq_enable otherwise irq_unmask is overridden.
2. hid: Many laptops can be woken up from Suspend-to-Idle by touchpad. This is
- also the default behavior on other OSes.
- However, if touchpad and touchscreen contact to each other when lid is
- closed, wakeup events can be triggered inadventertly.
- So let's disable the wakeup by default, but enable the wakeup capability
- so users can enable it at their own discretion.
+ also the default behavior on other OSes.
+ However, if touchpad and touchscreen contact to each other when lid is
+ closed, wakeup events can be triggered inadventertly.
+ So let's disable the wakeup by default, but enable the wakeup capability
+ so users can enable it at their own discretion.
[test]
- With the patch and enable HID's power/wakeup, the system can wake up by
touching the touchpad.
+ With the patch and manually enable HID's power/wakeup, the system can wake up
by touching the touchpad.
[Regression Potential]
Low. The two patches are already landed in the upstream.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1888331
Title:
Wakeup the system by touching the touchpad
To manage notifications about this bug go to:
https://bugs.launchpad.net/hwe-next/+bug/1888331/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
