Public bug reported: Upstream bug & fix:
https://github.com/collectd/collectd/issues/2951 https://github.com/collectd/collectd/pull/2952/commits/6ce52f70cc1e6450df3454f19743a29295b84050 $ git describe --contains 6ce52f70cc1e6450df3454f19743a29295b84050 collectd-5.8.1~3 => collectd | 5.7.2-2ubuntu1.1 | bionic-updates/universe collectd | 5.8.1-1.3ubuntu1 | eoan/universe collectd | 5.9.2.g-1ubuntu4 | focal/universe *Expected behavior: The disk plugin should export stats as it has done in the past *Actual behavior: No disk stats are exported at all * Steps to reproduce Run any of the 4.19-rc Linux kernels and probably any recent collectd version Cause With 4.19, Linux gained extra fields in /proc/diskstats, indicating r/w stats for Discard operations on SSDs. From linux/Documentation/iostats.txt: Field 12 -- # of discards completed This is the total number of discards completed successfully. Field 13 -- # of discards merged See the description of field 2 Field 14 -- # of sectors discarded This is the total number of sectors discarded successfully. Field 15 -- # of milliseconds spent discarding This is the total number of milliseconds spent by all discards (as measured from __make_request() to end_that_request_last()). Collectd simply quits parsing if the number of fields is not exactly what it expects. I think that may be overly conservative, since the nuber of fields usually only gets added to, without rearrangement of existing fields. I recommend making the checks for field numbers not X!=10 but X<10, that way, we don't lose stats in these cases, and can take time to implement parsing out extra stats if and when 4.19 becomes stable. ** Affects: collectd (Ubuntu) Importance: Undecided Status: Fix Released ** Affects: collectd (Ubuntu Bionic) Importance: Medium Assignee: Eric Desrochers (slashd) Status: In Progress ** Tags: sts ** Description changed: Upstream bug & fix: https://github.com/collectd/collectd/issues/2951 https://github.com/collectd/collectd/pull/2952/commits/6ce52f70cc1e6450df3454f19743a29295b84050 + + $ git describe --contains 6ce52f70cc1e6450df3454f19743a29295b84050 + collectd-5.8.1~3 + + => collectd | 5.7.2-2ubuntu1.1 | bionic-updates/universe + collectd | 5.8.1-1.3ubuntu1 | eoan/universe + collectd | 5.9.2.g-1ubuntu4 | focal/universe *Expected behavior: The disk plugin should export stats as it has done in the past *Actual behavior: No disk stats are exported at all * Steps to reproduce Run any of the 4.19-rc Linux kernels and probably any recent collectd version Cause With 4.19, Linux gained extra fields in /proc/diskstats, indicating r/w stats for Discard operations on SSDs. From linux/Documentation/iostats.txt: Field 12 -- # of discards completed - This is the total number of discards completed successfully. + This is the total number of discards completed successfully. Field 13 -- # of discards merged - See the description of field 2 + See the description of field 2 Field 14 -- # of sectors discarded - This is the total number of sectors discarded successfully. + This is the total number of sectors discarded successfully. Field 15 -- # of milliseconds spent discarding - This is the total number of milliseconds spent by all discards (as - measured from __make_request() to end_that_request_last()). + This is the total number of milliseconds spent by all discards (as + measured from __make_request() to end_that_request_last()). Collectd simply quits parsing if the number of fields is not exactly what it expects. I think that may be overly conservative, since the nuber of fields usually only gets added to, without rearrangement of existing fields. I recommend making the checks for field numbers not X!=10 but X<10, that way, we don't lose stats in these cases, and can take time to implement parsing out extra stats if and when 4.19 becomes stable. ** Also affects: collectd (Ubuntu Bionic) Importance: Undecided Status: New ** Changed in: collectd (Ubuntu) Status: New => Fix Released ** Changed in: collectd (Ubuntu Bionic) Assignee: (unassigned) => Eric Desrochers (slashd) ** Changed in: collectd (Ubuntu Bionic) Status: New => In Progress ** Changed in: collectd (Ubuntu Bionic) Importance: Undecided => Medium ** Tags added: sts -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1865895 Title: /proc/diskstats format changes in kernel v4.19 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/collectd/+bug/1865895/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
