** Description changed:

+ [Impact] 
+ Multiple FTBFS errors when building mongodb in cosmic.
+ 
+ - new gcc8 warnings (format-truncation and class-memaccess)
+ - -Wparentheses warning
+ - incompatibility with boost1.66+
+ 
+ 
+ [Test Case]
+ Rebuild mongodb in cosmic. Without these fixes, the build will fail. There is 
an additional fix needed for boost1.67 itself, which is being handled in bug 
#1821762
+ 
+ [Regression Potential] 
+ All bug the fix in boost1.67 mentioned above are due to new gcc8 checks, 
which suggests that mongodb was last built in cosmic before gcc8 became default.
+ 
+ [Other Info]
+ Mongo upstream nowadays has proper fixes for the format-truncation and 
class-memaccess warnings, but these were done[1] after the switch to the SSPL 
license[2] on October 16th, 2018. What I have done here is grab the fix we 
currently have in disco which was done by upstream[3] before that date.
+ 
+ 
+ [Original Description]
+ 
  mongodb 3.6.3 is currently failing to build in cosmic.
  
  https://launchpadlibrarian.net/416133571/buildlog_ubuntu-cosmic-
  amd64.mongodb_1%3A3.6.3-0ubuntu1.18.10.1_BUILDING.txt.gz
  
  They all seem to be about Werror=class-memaccess. Example:
  src/mongo/db/pipeline/value_internal.h:194:42: error: 'void* memmove(void*, 
const void*, size_t)' writing to an object of type 'class mongo::ValueStorage' 
with no trivial copy-assignment; use copy-assignment or copy-initialization 
instead [-Werror=class-memaccess]
-          memmove(this, &rhs, sizeof(*this));
-                                           ^
+          memmove(this, &rhs, sizeof(*this));
+                                           ^
  src/mongo/db/pipeline/value_internal.h:78:7: note: 'class 
mongo::ValueStorage' declared here
- 
  
  And, of course:
  cc1plus: all warnings being treated as errors
+ 
+ 
+ 1. 
https://github.com/mongodb/mongo/commit/76b0fcea6960274d23a3bd1245a0e55e3cb08369
 and 
https://github.com/mongodb/mongo/commit/f53ed89cef7c4356789114b2de1a5294e3d7a6f7
+ 2. https://www.mongodb.com/licensing/server-side-public-license/faq
+ 3. 
https://github.com/mongodb/mongo/commit/168c8d65556ab18b05e33b5f4006d1184c30f8f7

** Description changed:

- [Impact] 
+ [Impact]
  Multiple FTBFS errors when building mongodb in cosmic.
  
  - new gcc8 warnings (format-truncation and class-memaccess)
  - -Wparentheses warning
  - incompatibility with boost1.66+
  
- 
  [Test Case]
  Rebuild mongodb in cosmic. Without these fixes, the build will fail. There is 
an additional fix needed for boost1.67 itself, which is being handled in bug 
#1821762
  
- [Regression Potential] 
- All bug the fix in boost1.67 mentioned above are due to new gcc8 checks, 
which suggests that mongodb was last built in cosmic before gcc8 became default.
+ [Regression Potential]
+ All but the fix in boost1.67 mentioned above are due to new gcc8 checks, 
which suggests that mongodb was last built in cosmic before gcc8 became default.
  
  [Other Info]
  Mongo upstream nowadays has proper fixes for the format-truncation and 
class-memaccess warnings, but these were done[1] after the switch to the SSPL 
license[2] on October 16th, 2018. What I have done here is grab the fix we 
currently have in disco which was done by upstream[3] before that date.
- 
  
  [Original Description]
  
  mongodb 3.6.3 is currently failing to build in cosmic.
  
  https://launchpadlibrarian.net/416133571/buildlog_ubuntu-cosmic-
  amd64.mongodb_1%3A3.6.3-0ubuntu1.18.10.1_BUILDING.txt.gz
  
  They all seem to be about Werror=class-memaccess. Example:
  src/mongo/db/pipeline/value_internal.h:194:42: error: 'void* memmove(void*, 
const void*, size_t)' writing to an object of type 'class mongo::ValueStorage' 
with no trivial copy-assignment; use copy-assignment or copy-initialization 
instead [-Werror=class-memaccess]
           memmove(this, &rhs, sizeof(*this));
                                            ^
  src/mongo/db/pipeline/value_internal.h:78:7: note: 'class 
mongo::ValueStorage' declared here
  
  And, of course:
  cc1plus: all warnings being treated as errors
  
- 
  1. 
https://github.com/mongodb/mongo/commit/76b0fcea6960274d23a3bd1245a0e55e3cb08369
 and 
https://github.com/mongodb/mongo/commit/f53ed89cef7c4356789114b2de1a5294e3d7a6f7
  2. https://www.mongodb.com/licensing/server-side-public-license/faq
  3. 
https://github.com/mongodb/mongo/commit/168c8d65556ab18b05e33b5f4006d1184c30f8f7

** Description changed:

  [Impact]
- Multiple FTBFS errors when building mongodb in cosmic.
+ Multiple FTBFS errors when building mongodb in cosmic. This prevents mongodb 
from being SRUed, and such an SRU need has appeared in bug #1821391. The FTBFS 
issues in cosmic are:
  
  - new gcc8 warnings (format-truncation and class-memaccess)
  - -Wparentheses warning
  - incompatibility with boost1.66+
  
+ There is an additional fix needed for boost1.67 itself, which is being
+ handled in bug #1821762.
+ 
  [Test Case]
- Rebuild mongodb in cosmic. Without these fixes, the build will fail. There is 
an additional fix needed for boost1.67 itself, which is being handled in bug 
#1821762
- 
+ Rebuild mongodb in cosmic. Without these fixes, the build will fail.
  [Regression Potential]
  All but the fix in boost1.67 mentioned above are due to new gcc8 checks, 
which suggests that mongodb was last built in cosmic before gcc8 became default.
  
  [Other Info]
  Mongo upstream nowadays has proper fixes for the format-truncation and 
class-memaccess warnings, but these were done[1] after the switch to the SSPL 
license[2] on October 16th, 2018. What I have done here is grab the fix we 
currently have in disco which was done by upstream[3] before that date.
  
  [Original Description]
  
  mongodb 3.6.3 is currently failing to build in cosmic.
  
  https://launchpadlibrarian.net/416133571/buildlog_ubuntu-cosmic-
  amd64.mongodb_1%3A3.6.3-0ubuntu1.18.10.1_BUILDING.txt.gz
  
  They all seem to be about Werror=class-memaccess. Example:
  src/mongo/db/pipeline/value_internal.h:194:42: error: 'void* memmove(void*, 
const void*, size_t)' writing to an object of type 'class mongo::ValueStorage' 
with no trivial copy-assignment; use copy-assignment or copy-initialization 
instead [-Werror=class-memaccess]
           memmove(this, &rhs, sizeof(*this));
                                            ^
  src/mongo/db/pipeline/value_internal.h:78:7: note: 'class 
mongo::ValueStorage' declared here
  
  And, of course:
  cc1plus: all warnings being treated as errors
  
  1. 
https://github.com/mongodb/mongo/commit/76b0fcea6960274d23a3bd1245a0e55e3cb08369
 and 
https://github.com/mongodb/mongo/commit/f53ed89cef7c4356789114b2de1a5294e3d7a6f7
  2. https://www.mongodb.com/licensing/server-side-public-license/faq
  3. 
https://github.com/mongodb/mongo/commit/168c8d65556ab18b05e33b5f4006d1184c30f8f7

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1821361

Title:
  cosmic FTBFS

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/mongodb/+bug/1821361/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to