After discussion with upstream, fixing the second test case (parallel
usage of adduser) is too intrusive to fix for stable releases. It will
be fixed eventually in Gnome 2.21. So let's confine this SRU to the
first test case of only using g-s-t for user administration.

This is the proposed changelog:

gnome-system-tools (2.20.0-0ubuntu2) gutsy-proposed; urgency=low

  * Add debian/patches/23_users_update_model.patch:
    - Update the internal model of users and groups with each operation, so
      that it does not become inconsistent with the real world in /etc/passwd
      and /etc/group.
    - This fixes random errors like "unrelated user was dropped from group
      admin", "deleted a different user than the one selected in users-admin",
      etc.
    - Patch backported from SVN head:
      http://svn.gnome.org/viewvc/gnome-system-tools?view=revision&revision=4017
    - LP: #26338

 -- Martin Pitt <[EMAIL PROTECTED]>  Tue, 13 Nov 2007 11:26:21
+0100

Attaching the corresponding dpatch.

I verified that with this patch the test case is fixed.

** Description changed:

  Impact:
  gnome-system-tools does not keep its internal model of users and groups 
consistent with the real world in /etc/passwd, /etc/shadow, and /etc/group. 
This leads to errors like deleting a different user than the one you chose in 
the UI, dropping unrelated users from groups like admin (thus making the system 
inaccessible for administration), and similar effects.
  
  Fix:
  Update the internal world model with each operation, done in 
http://svn.gnome.org/viewvc/gnome-system-tools?view=revision&revision=4017. 
This needs some serious backporting for Feisty and earlier, I suppose; it 
should apply well to Gutsy.
  
  Regression potential: The bug could not be fixed fully, there might be
  more places which need update calls. Potentially the patch could mess up
  the pam db even more.
  
  TEST CASE:
  1. launch users-admin
  2. create a test1 user
  3. create a test2 user (with admin rights)
  4. create a test3 user
  5. delete the test1 user
  6. delete the test3 user
  
  This will either cause test2 to not be in group admin any more, or be
  deleted in step 6 instead of user test3.
- 
- Another one:
- 1. launch users-admin
- 2. create test1 user in users-admin
- 3. "sudo useradd test2" in terminal
- 4. create test3 user in users-admin
- 5. "id test2" will show that user test2 has been nuked.

** Attachment added: "gutsy dpatch"
   http://launchpadlibrarian.net/10350298/23_users_update_model.patch

-- 
Changing users randomly affects other users and group memberships
https://bugs.launchpad.net/bugs/26338
You received this bug notification because you are a member of Ubuntu
Bugs, which is a direct subscriber.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to